adds function on colormap objects to set RGB values #1553
Conversation
| @@ -0,0 +1,10 @@ | |||
| import vcs | |||
There was a problem hiding this comment.
Instead of making two tests.. can you just make one? We have lot many tests and now we need to make sure that we don't grow the number as much
There was a problem hiding this comment.
I like one test per issue. So we know exactly what broke.
There was a problem hiding this comment.
@doutriaux1 like I said, we are having too many tests. In this case, I think you can easily put both of them together into one as they are testing getter and setters.
There was a problem hiding this comment.
no, we have established a policy of one test per feature. It takes 2 seconds at most to run, this will save one second.
|
per feature not per getter and setter. Also, @williams13 bought this issue as well. Even if you are writing unit tests, you can include them in one file vs having each into own separate file. The main thing is you are testing the code (the lines). Having a very large number of test files is not good either. |
|
I am just suggesting best software practices. I understanding if you are testing a feature (math, model of some sort etc) then yes, having individual tests help. |
|
@jbeezley paranthesis closed in add_test too early. Pushing a fix now. |
|
In this particular case, I think the tests could be combined into one, but in general I don't think there is such a thing as "too many tests" in any practical sense. There is a point at which testing can become too slow, but I would argue it being a result of either a bad unit testing framework (i.e. lots of setup code, not mocking process intensive components) or a fundamental problem with software itself (i.e. orthogonal components cannot be tested independently). |
|
@aashish24 go ahead if you have time, push an update to the branch. |
@jbeezley I agree with most of you said. Like I said earlier, unnecessarily increasing number of test files is not a good practice unless required. If we can combine tests into one file that would be great. This is particularly true for unit tests which is pretty much what we have in this branch. More testing is good though. I didn't mean that. We should continue to add more tests to increase code coverage. |
|
Will do later today @doutriaux1 thanks. |
|
I don't think the number of test files is a useful metric for anything. My point is that, assuming identical coverage, more tests is better than fewer tests. |
|
Agree @jbeezley 👍 We are on the same page. |
|
@aashish24 so you are on the same page as @jbeezley two files are better than one 😉
|
Jon said that in this particular case one is better (I was saying the same). One is better in this case, in some other cases two or more is desired. |
aashish24
force-pushed
the
issue_1484_colormap_setcolorcell
branch
from
a345ffa to
2bf875a
Compare
…_setcolorcell Conflicts: testing/vcs/CMakeLists.txt
|
@aashish24 any idea what happened on crunchy? |
|
@doutriaux1 no idea. Its only one test failing on crunchy... I think the changes are safe enough so I am willing to merge it. |
|
LGTM 👍 |
adds function on colormap objects to set RGB values
fix #1484