New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1347 use screensize #1563

Merged
merged 16 commits into from Sep 23, 2015

Conversation

Projects
None yet
4 participants
@aashish24
Contributor

aashish24 commented Sep 22, 2015

No description provided.

doutriaux1 and others added some commits Sep 14, 2015

VTK let us get screen size again from python
using this feature and reintroducing use to size keyword in vcs.init()
fix #1347
Merge remote-tracking branch 'origin/master' into issue_1347_use_scre…
…ensize

Conflicts:
	testing/vcs/CMakeLists.txt
Added a few comments
##bot##skip-commit
@durack1

This comment has been minimized.

Member

durack1 commented Sep 22, 2015

@aashish24 it seems that garant is having some problems, it's failed here and also on #1540..

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

@doutriaux1 looks like one test is failing. Although I don't know how its related to your change.

@durack1

This comment has been minimized.

Member

durack1 commented Sep 22, 2015

@aashish24 as noted above it seems that garant is having configuration problems, rather than failing the ctest suite..

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Sep 22, 2015

Not sure the issue, but this is the cmake output:

CMake Error: Error in cmake code at
/home/buildbot/buildbot/uvcdat-garant-linux-release/source/testing/vcs/CMakeLists.txt:35:
Parse error.  Expected a command name, got quoted argument with text "${PYTHON_EXECUTABLE}".
[INFO] You did not download UVCMETRICS Test data not test will be run
-- Configuring incomplete, errors occurred!
@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Sep 22, 2015

There is definitely a syntax error at that line. I'm not sure why it isn't failing on the other machines.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

@jbeezley fixing now. Thx for spotting.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

@jbeezley I pushed a fix

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

@aashish24 you beat me to it. Thx.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

😸

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

@doutriaux1 we are getting this:

self.__plot(arglist, keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/Canvas.py", line 3839, in __plot
returned_kargs = self.backend.plot(_arglist, _keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 445, in plot
self.createRenWin(
kargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 314, in createRenWin
self.initialSize()
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 412, in initialSize
bgX = int(screenSize[0]
.6)
TypeError: can't multiply sequence by non-int of type 'float'

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

Looks like VTK still giving us a pointer.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

did that got reverted? I works in what uvcdat-master we had last week.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

@aashish24 garant seems to be hosed?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

@aashish24 why are travis builds suddenly failing because of wrong version of cmake?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 22, 2015

now goes with: CDAT/uvcdat-testdata#66

doutriaux1 added some commits Sep 23, 2015

Added keyword to turn off baseline branch matching magic
ctest -D Experimental on bots detached head reverts to master always
made the branch magic flag a cmake option
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
correct cmake syntax to turn on/off magic flag
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
I think I finally commented out enough...
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley no matter what ctest -D Experimental switch the branch back to master sooooo annoying....

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley why does ctest resets the branch to master!

@doutriaux1 doutriaux1 force-pushed the issue_1347_use_screensize branch from d049702 to f1bb222 Sep 23, 2015

@@ -55,194 +55,202 @@ if(NOT EXISTS "${TESTDATA_DIR}")
endif()
endif()
# 2) Is TESTDATA_DIR a clone of TESTDATA_URL?
execute_process(COMMAND

This comment has been minimized.

@aashish24

aashish24 Sep 23, 2015

Contributor

What's changed?

This comment has been minimized.

@doutriaux1

doutriaux1 Sep 23, 2015

Member

indentation, it's now in an if loop

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley I got it! RH6 FULL is passing! Retriggering it on all machines now.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 23, 2015

what was the issue?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

xtra cmake args from commit were not parsed correctly by bot slaves

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

I updated the slaves to send the command all the time, this latest commit doesn't send any extra args to slaves so we will see if the system works properly now.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 23, 2015

@aashish24 we need this to test all pending branches with new baselines please approve quick.

doutriaux1 added a commit that referenced this pull request Sep 23, 2015

Merge pull request #1563 from UV-CDAT/issue_1347_use_screensize
Issue 1347 use screen size

Can't wait any longer @aashish24 merging, we really needs this in in order to move forward for the rc.

fix #1347

@doutriaux1 doutriaux1 merged commit e1e4f40 into master Sep 23, 2015

3 of 7 checks passed

cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'make -j15' (Wed Sep 23 11:36:32 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
cont-int/LLNL/Darwin-Mac 10.10.3 running 'ctest -j4 -D Experimental' (Wed Sep 23 12:34:28 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Wed Sep 23 11:25:50 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Wed Sep 23 11:20:56 2015)
Details

@doutriaux1 doutriaux1 deleted the issue_1347_use_screensize branch Sep 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment