Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1347 use screensize #1563

Merged
merged 16 commits into from Sep 23, 2015
Merged

Issue 1347 use screensize #1563

merged 16 commits into from Sep 23, 2015

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 22, 2015

No description provided.

@durack1
Copy link
Member

@durack1 durack1 commented Sep 22, 2015

@aashish24 it seems that garant is having some problems, it's failed here and also on #1540..

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 22, 2015

@doutriaux1 looks like one test is failing. Although I don't know how its related to your change.

@durack1
Copy link
Member

@durack1 durack1 commented Sep 22, 2015

@aashish24 as noted above it seems that garant is having configuration problems, rather than failing the ctest suite..

@jbeezley
Copy link

@jbeezley jbeezley commented Sep 22, 2015

Not sure the issue, but this is the cmake output:

CMake Error: Error in cmake code at
/home/buildbot/buildbot/uvcdat-garant-linux-release/source/testing/vcs/CMakeLists.txt:35:
Parse error.  Expected a command name, got quoted argument with text "${PYTHON_EXECUTABLE}".
[INFO] You did not download UVCMETRICS Test data not test will be run
-- Configuring incomplete, errors occurred!

@jbeezley
Copy link

@jbeezley jbeezley commented Sep 22, 2015

There is definitely a syntax error at that line. I'm not sure why it isn't failing on the other machines.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

@jbeezley fixing now. Thx for spotting.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 22, 2015

@jbeezley I pushed a fix

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

@aashish24 you beat me to it. Thx.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 22, 2015

😸

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 22, 2015

@doutriaux1 we are getting this:

self.__plot(arglist, keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/Canvas.py", line 3839, in __plot
returned_kargs = self.backend.plot(_arglist, _keyargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 445, in plot
self.createRenWin(
kargs)
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 314, in createRenWin
self.initialSize()
File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/lib/python2.7/site-packages/vcs/VTKPlots.py", line 412, in initialSize
bgX = int(screenSize[0]
.6)
TypeError: can't multiply sequence by non-int of type 'float'

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 22, 2015

Looks like VTK still giving us a pointer.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

did that got reverted? I works in what uvcdat-master we had last week.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

@aashish24 garant seems to be hosed?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

@aashish24 why are travis builds suddenly failing because of wrong version of cmake?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 22, 2015

now goes with: CDAT/uvcdat-testdata#66

doutriaux1 added 5 commits Sep 23, 2015
ctest -D Experimental on bots detached head reverts to master always
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
##bot##cmake_xtra -DCDAT_CHECKOUT_BASELINE_MATCHING_BRANCH=OFF
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley no matter what ctest -D Experimental switch the branch back to master sooooo annoying....

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley why does ctest resets the branch to master!

@doutriaux1 doutriaux1 force-pushed the issue_1347_use_screensize branch from d049702 to f1bb222 Sep 23, 2015
@@ -55,194 +55,202 @@ if(NOT EXISTS "${TESTDATA_DIR}")
endif()
endif()

# 2) Is TESTDATA_DIR a clone of TESTDATA_URL?
execute_process(COMMAND
Copy link
Contributor Author

@aashish24 aashish24 Sep 23, 2015

What's changed?

Copy link
Contributor

@doutriaux1 doutriaux1 Sep 23, 2015

indentation, it's now in an if loop

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

@aashish24 @jbeezley I got it! RH6 FULL is passing! Retriggering it on all machines now.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 23, 2015

what was the issue?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

xtra cmake args from commit were not parsed correctly by bot slaves

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

I updated the slaves to send the command all the time, this latest commit doesn't send any extra args to slaves so we will see if the system works properly now.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 23, 2015

@aashish24 we need this to test all pending branches with new baselines please approve quick.

doutriaux1 added a commit that referenced this issue Sep 23, 2015
Issue 1347 use screen size

Can't wait any longer @aashish24 merging, we really needs this in in order to move forward for the rc.

fix #1347
@doutriaux1 doutriaux1 merged commit e1e4f40 into master Sep 23, 2015
3 of 7 checks passed
@doutriaux1 doutriaux1 deleted the issue_1347_use_screensize branch Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants