Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1577 boxfill patterns #1582

Merged
merged 4 commits into from Oct 7, 2015
Merged

1577 boxfill patterns #1582

merged 4 commits into from Oct 7, 2015

Conversation

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Oct 5, 2015

Fixes #1577
Baselines added in CDAT/uvcdat-testdata#71

sankhesh added 3 commits Oct 1, 2015
Do not pass patterning arguments to legend fillarea when using
non-custom boxfill types.
Fixes #1577
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 5, 2015

@sankhesh seems to be failing

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 6, 2015

@doutriaux1 Tests are passing now. The remaining failures are due to uvcdat-testdata not being fetched from the right branch on the dashboard machines. Not sure what is the reason.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 7, 2015

@doutriaux1 @sankhesh are we good with this branch then?

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 7, 2015

Yes. Needs review and merge.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 7, 2015

yes we are good but I want to figure out why the baselines are not checked out anymore.

doutriaux1 added a commit that referenced this issue Oct 7, 2015
@doutriaux1 doutriaux1 merged commit 6c3e29f into master Oct 7, 2015
3 of 9 checks passed
@doutriaux1 doutriaux1 deleted the 1577_boxfill_patterns branch Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants