New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1577 boxfill patterns #1582

Merged
merged 4 commits into from Oct 7, 2015

Conversation

Projects
None yet
3 participants
@sankhesh
Contributor

sankhesh commented Oct 5, 2015

Fixes #1577
Baselines added in CDAT/uvcdat-testdata#71

sankhesh added some commits Oct 1, 2015

Color bar rendering for non-custom boxfill types
Do not pass patterning arguments to legend fillarea when using
non-custom boxfill types.
Fixes #1577
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 5, 2015

@sankhesh seems to be failing

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 6, 2015

@doutriaux1 Tests are passing now. The remaining failures are due to uvcdat-testdata not being fetched from the right branch on the dashboard machines. Not sure what is the reason.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 7, 2015

@doutriaux1 @sankhesh are we good with this branch then?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 7, 2015

Yes. Needs review and merge.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 7, 2015

yes we are good but I want to figure out why the baselines are not checked out anymore.

doutriaux1 added a commit that referenced this pull request Oct 7, 2015

@doutriaux1 doutriaux1 merged commit 6c3e29f into master Oct 7, 2015

3 of 9 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Wed Oct 7 11:33:19 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'make -j4' (Wed Oct 7 11:15:06 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'In Queue: 4' (Wed Oct 7 10:36:12 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'In Queue: 4' (Wed Oct 7 10:36:11 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'In Queue: 4' (Wed Oct 7 10:36:08 2015)
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Wed Oct 7 10:47:43 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the 1577_boxfill_patterns branch Oct 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment