New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 thermo #1587

Merged
merged 3 commits into from Oct 7, 2015

Conversation

Projects
None yet
3 participants
@sankhesh
Contributor

sankhesh commented Oct 6, 2015

Fixes #1416

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 6, 2015

@sankhesh we need to tell flake8 to accept line up to 120 characters.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 6, 2015

@sankhesh also can you please move the files in Test into the testing directory the nc file should go in uvcdat-testdata/data/Thermo or something similar, look at my WK branch. Thx.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 6, 2015

@doutriaux1 Sure thing.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 6, 2015

@doutriaux1 Looking at your WK branch to make similar changes to Thermo. I see that you moved the Packages/WK/Test/*.py to testing/WK/*.py. Why not delete the Packages/WK/Test/ folder now?

EDIT:
Sorry I see that you removed the Test folder altogether.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 7, 2015

@doutriaux1 Thermo testing changes are in the thermo_testing branch.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Oct 7, 2015

@doutriaux1 All tests are passing here. Needs review and merge.

doutriaux1 added a commit that referenced this pull request Oct 7, 2015

@doutriaux1 doutriaux1 merged commit 509611a into master Oct 7, 2015

5 of 9 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'In Queue: 2' (Tue Oct 6 18:54:48 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'In Queue: 2' (Tue Oct 6 18:54:48 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'In Queue: 2' (Tue Oct 6 18:54:46 2015)
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Tue Oct 6 19:13:06 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Tue Oct 6 21:24:11 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Tue Oct 6 22:23:53 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sankhesh sankhesh deleted the flake8_thermo branch Dec 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment