Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 thermo #1587

Merged
merged 3 commits into from Oct 7, 2015
Merged

Flake8 thermo #1587

merged 3 commits into from Oct 7, 2015

Conversation

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Oct 6, 2015

Fixes #1416

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 6, 2015

@sankhesh we need to tell flake8 to accept line up to 120 characters.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 6, 2015

@sankhesh also can you please move the files in Test into the testing directory the nc file should go in uvcdat-testdata/data/Thermo or something similar, look at my WK branch. Thx.

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 6, 2015

@doutriaux1 Sure thing.

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 6, 2015

@doutriaux1 Looking at your WK branch to make similar changes to Thermo. I see that you moved the Packages/WK/Test/*.py to testing/WK/*.py. Why not delete the Packages/WK/Test/ folder now?

EDIT:
Sorry I see that you removed the Test folder altogether.

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 7, 2015

@doutriaux1 Thermo testing changes are in the thermo_testing branch.

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Oct 7, 2015

@doutriaux1 All tests are passing here. Needs review and merge.

doutriaux1 added a commit that referenced this issue Oct 7, 2015
@doutriaux1 doutriaux1 merged commit 509611a into master Oct 7, 2015
5 of 9 checks passed
@sankhesh sankhesh deleted the flake8_thermo branch Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants