Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1585 ez template tweaks #1591

Merged
merged 4 commits into from Oct 9, 2015
Merged

Issue 1585 ez template tweaks #1591

merged 4 commits into from Oct 9, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 6, 2015

No description provided.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 7, 2015

@doutriaux1 what is a ez template?

Loading

@durack1
Copy link
Member

@durack1 durack1 commented Oct 7, 2015

@aashish24 take a peek at the EzTemplates here

Loading

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 7, 2015

Hard to review the changes..but looks like cdash is happy. I am giving +1. Someone else should reivew it.

Thanks @durack1

Loading

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Oct 7, 2015

@chaosphere2112 please review and approve don't worry about the W>H I improved this logic in #1595

Loading

@durack1
Copy link
Member

@durack1 durack1 commented Oct 8, 2015

@doutriaux1 if I'm reading this correctly it resolves #1423 - fix #1423?

Loading

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Oct 8, 2015

@durack1 yes.

Loading

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Oct 9, 2015

@doutriaux1 I'm testing this one now, then I'll move over to #1595

Loading

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Oct 9, 2015

@doutriaux1 I ran into some failed tests, but none of them look related to this (all of them are CDMS, I think). 👍 from me.

Loading

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 9, 2015

+2

Loading

aashish24 added a commit that referenced this issue Oct 9, 2015
@aashish24 aashish24 merged commit 7935193 into master Oct 9, 2015
5 of 9 checks passed
Loading
@aashish24 aashish24 deleted the issue_1585_EzTemplate_tweaks branch Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants