Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set non parallel flag for cdscan #1600

Merged
merged 1 commit into from Oct 9, 2015
Merged

set non parallel flag for cdscan #1600

merged 1 commit into from Oct 9, 2015

Conversation

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Oct 8, 2015

No description provided.

durack1
Copy link
Member

durack1 commented on e100918 Oct 8, 2015

@dnadeau4 would this be better set just below the cdms2 import statement at the top of the file? Keeping these config/import things together would make it easier to figure out what is happening..

This is also true for the numpy.set_printoptions() call a couple of lines above too..

dnadeau4
Copy link
Contributor

dnadeau4 commented on e100918 Oct 8, 2015

On top of the file with the import we might miss it.

I think it goes well with the initializations just before the code section. It is part of the global variable section where flags and defaults are set.

durack1
Copy link
Member

durack1 commented on e100918 Oct 9, 2015

@dnadeau4 ok, just thought I'd raise the question..

doutriaux1 added a commit that referenced this issue Oct 9, 2015
set non parallel flag for cdscan
@doutriaux1 doutriaux1 merged commit 27fb0bb into master Oct 9, 2015
3 of 9 checks passed
@doutriaux1 doutriaux1 deleted the cdscannonparallel branch Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants