New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue png size updated #1604

Merged
merged 16 commits into from Oct 12, 2015

Conversation

Projects
None yet
4 participants
@aashish24
Contributor

aashish24 commented Oct 9, 2015

No description provided.

@aashish24 aashish24 referenced this pull request Oct 9, 2015

Closed

respects png sizes #1595

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 9, 2015

@aashish24 why did you rerun with master in? The bots do that for us automatically.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 9, 2015

@doutriaux1 looks like build is broken on garant @jbeezley is this new?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 9, 2015

@doutriaux1 so that we can see the diffs clearly. Please see our conversation (Sam, Deanue, and myself on the last PR).

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Oct 9, 2015

I haven't seen that particular error before, but it could be related to the Cython build race condition we've seen in the past. I retriggered the build just in case.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 9, 2015

@doutriaux1 please avoid commits like:

| ok this time should have everything going

Can you squash your commits?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 11, 2015

@aashish24 sure...

@doutriaux1 doutriaux1 force-pushed the issue_png_size_updated branch from 2f478a0 to 8a45e51 Oct 11, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 11, 2015

@aashish24 will let the bot run. And will merge in the morning. Not sure it was worth holding the RC tag but it's done now.

doutriaux1 added a commit that referenced this pull request Oct 12, 2015

@doutriaux1 doutriaux1 merged commit 765ca27 into master Oct 12, 2015

6 of 9 checks passed

cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Sat Oct 10 22:29:31 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'In Queue: 2' (Sat Oct 10 21:53:29 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Sat Oct 10 23:02:29 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Sat Oct 10 23:33:45 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Sat Oct 10 22:43:45 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Sat Oct 10 22:21:08 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the issue_png_size_updated branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment