-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pattern 9 #1605
Fix pattern 9 #1605
Conversation
@sankhesh You'll want to take a peek to make sure I didn't mess anything up in here. |
@chaosphere2112 darn your baseline somehow dosen't let master baseline be merged into it. I wonder why. Did you start the baseline branch a while back? |
👏 : @chaosphere2112 what was the reason for the slow down? |
@aashish24
it is instead drawn like so:
and then rotated 45 degrees. I was able to dramatically reduce the number of draw calls (1 per column and row, and 1 per intersection) as well as using the speedier |
thanks @chaosphere2112 so how did you trace FillTube timings? Also, thanks for changing the name from draw to paint. Actually "create" or "construct" would have better, but I am okay with paint. |
I just used |
Thanks, it would be nice to document developer tips somewhere... |
@sankhesh the changes looks good to me but you are the original author. Please review. |
@aashish24 Documentation for that is pretty much the top google result for "profile python" 😉 |
😆 sure, I meant in a large sense.. not just for this. We need more extensive developers documentation. |
👍 |
This PR substantially speeds up pattern 9 (no longer takes most of a minute!). It also refactors the patterns/hatches to be classes, which will let us do some cool stuff later down the line (like custom patterns) and makes it so the logic for fetching a specific pattern is less hardcoded (again, making it easier to add custom patterns later). Matching testdata PR is at CDAT/uvcdat-testdata#73