Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turned off the keep flag that prevented to test results #1615

merged 8 commits into from Oct 26, 2015


Copy link

@mcenerney1 mcenerney1 commented Oct 14, 2015

added antialiasing keyword

Copy link

@aashish24 aashish24 commented Oct 15, 2015

@mcenerney1 why setting threshold to None?

Copy link

@doutriaux1 doutriaux1 commented Oct 16, 2015

@aashish24 these are my changes (pushed from @mcenerney1 computer). I set it to None to mean "use default threshold" if set to another value then the test will use that value.

@@ -82,6 +83,8 @@ def closeness( self, varname, filename, rtol, atol ):
return close
def execute(self, test_str, imagefilename, imagethreshold, ncfiles, rtol, atol):
print test_str
if imagethreshold is None: # user didn't specify a value
Copy link

@doutriaux1 doutriaux1 Oct 16, 2015

@aashish24 this is why we have None

Copy link

@aashish24 aashish24 Oct 17, 2015

ah thanks @doutriaux1

Copy link

@aashish24 aashish24 commented Oct 17, 2015

@mcenerney1 diagnostics tests are failing.

492/495 Test #490: diags_test_11 ..........................................._Failed 49.84 sec
Start 491: diags_test_12
493/495 Test #491: diags_test_12 ...........................................
_Failed 15.71 sec

doutriaux1 added a commit that referenced this issue Oct 26, 2015
turned off the keep flag that prevented to test results
@doutriaux1 doutriaux1 merged commit b32e99c into master Oct 26, 2015
6 of 9 checks passed
@doutriaux1 doutriaux1 deleted the uvcmerics_test_suite_fix branch Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants