turned off the keep flag that prevented to test results #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added antialiasing keyword
|
@mcenerney1 why setting threshold to None? |
|
@aashish24 these are my changes (pushed from @mcenerney1 computer). I set it to None to mean "use default threshold" if set to another value then the test will use that value. |
| @@ -82,6 +83,8 @@ def closeness( self, varname, filename, rtol, atol ): | |||
| return close | |||
| def execute(self, test_str, imagefilename, imagethreshold, ncfiles, rtol, atol): | |||
| print test_str | |||
| if imagethreshold is None: # user didn't specify a value | |||
There was a problem hiding this comment.
@aashish24 this is why we have None
|
@mcenerney1 diagnostics tests are failing. 492/495 Test #490: diags_test_11 ..........................................._Failed 49.84 sec |
doutriaux1
added a commit
that referenced
this pull request
Oct 26, 2015
turned off the keep flag that prevented to test results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added antialiasing keyword