New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turned off the keep flag that prevented to test results #1615

Merged
merged 8 commits into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@mcenerney1
Contributor

mcenerney1 commented Oct 14, 2015

added antialiasing keyword

McEnerney
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 15, 2015

@mcenerney1 why setting threshold to None?

McEnerney
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 16, 2015

@aashish24 these are my changes (pushed from @mcenerney1 computer). I set it to None to mean "use default threshold" if set to another value then the test will use that value.

@@ -82,6 +83,8 @@ def closeness( self, varname, filename, rtol, atol ):
return close
def execute(self, test_str, imagefilename, imagethreshold, ncfiles, rtol, atol):
print test_str
if imagethreshold is None: # user didn't specify a value

This comment has been minimized.

@doutriaux1

doutriaux1 Oct 16, 2015

Member

@aashish24 this is why we have None

This comment has been minimized.

@aashish24

aashish24 Oct 17, 2015

Contributor

ah thanks @doutriaux1

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 17, 2015

@mcenerney1 diagnostics tests are failing.

492/495 Test #490: diags_test_11 ..........................................._Failed 49.84 sec
Start 491: diags_test_12
493/495 Test #491: diags_test_12 ...........................................
_Failed 15.71 sec

doutriaux1 added a commit that referenced this pull request Oct 26, 2015

Merge pull request #1615 from UV-CDAT/uvcmerics_test_suite_fix
turned off the keep flag that prevented to test results

@doutriaux1 doutriaux1 merged commit b32e99c into master Oct 26, 2015

6 of 9 checks passed

cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Mon Oct 26 14:19:52 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'make -j4' (Mon Oct 26 13:58:24 2015)
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Mon Oct 26 14:02:44 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Mon Oct 26 15:24:05 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Mon Oct 26 14:38:01 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Mon Oct 26 14:15:25 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the uvcmerics_test_suite_fix branch Oct 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment