Fix TextCombined used wrong #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1606 |
|
@chaosphere2112 is Jerry going to approve this branch? Changes looks reasonable to me 👍 |
|
@glpotter, you can try this branch out; I was able to reproduce every time I was placing a label in the VCS Interactive layer. |
added colormap attribute to textcombined
|
@chaosphere2112 I added colormap to textcombined as well. Let's wait for the bots. |
|
@chaosphere2112 LGTM. If okay with @doutriaux1 please feel free to merge. |
doutriaux1
added a commit
that referenced
this pull request
Oct 19, 2015
Fix TextCombined used wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes where TextCombined was passed into vcs2vtk.prepTextProperty; now uses TextOrientation and TextTable instead.