Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextCombined used wrong #1616

Merged
merged 2 commits into from Oct 19, 2015
Merged

Fix TextCombined used wrong #1616

merged 2 commits into from Oct 19, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Oct 15, 2015

Fixes where TextCombined was passed into vcs2vtk.prepTextProperty; now uses TextOrientation and TextTable instead.

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Oct 15, 2015

Fixes #1606

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 15, 2015

@chaosphere2112 is Jerry going to approve this branch? Changes looks reasonable to me 👍

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Oct 16, 2015

@glpotter, you can try this branch out; I was able to reproduce every time I was placing a label in the VCS Interactive layer.

added colormap attribute to textcombined
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 16, 2015

@chaosphere2112 I added colormap to textcombined as well. Let's wait for the bots.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 17, 2015

@chaosphere2112 LGTM. If okay with @doutriaux1 please feel free to merge.

doutriaux1 added a commit that referenced this issue Oct 19, 2015
Fix TextCombined used wrong
@doutriaux1 doutriaux1 merged commit 9bdd87f into master Oct 19, 2015
6 of 8 checks passed
@doutriaux1 doutriaux1 deleted the fix_1606 branch Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants