Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1281 default marker size too small #1617

Merged
merged 1 commit into from Oct 16, 2015
Merged

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 16, 2015

also let the marker size by any positive number so if users find it too big they can make it smaller

also let the marker size by any positive number so if users find it too big they can make it smaller
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Oct 16, 2015

@aashish24 @sankhesh @chaosphere2112 after the bots are done please review
goes with: CDAT/uvcdat-testdata#76

@@ -1214,6 +1214,7 @@ def prepGlyph(g, marker, index=0):
if t == 'dot':
gs.SetGlyphTypeToCircle()
gs.FilledOn()
s *= numpy.pi
Copy link
Contributor

@aashish24 aashish24 Oct 16, 2015

Why not make it a integer number say 10, 20? it may help if we are going to do pixel align rendering.

Copy link
Contributor Author

@doutriaux1 doutriaux1 Oct 16, 2015

I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.

Copy link
Contributor

@aashish24 aashish24 Oct 16, 2015

I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.

I see. I am bit surprised that s is not an integer.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 16, 2015

other than that it LGTM 👍

aashish24 added a commit that referenced this issue Oct 16, 2015
@aashish24 aashish24 merged commit 6a4609c into master Oct 16, 2015
7 checks passed
@aashish24 aashish24 deleted the issue_1281_bigger_dots branch Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants