New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1281 default marker size too small #1617

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Oct 16, 2015

also let the marker size by any positive number so if users find it too big they can make it smaller

fix #1281 default marker size too small
also let the marker size by any positive number so if users find it too big they can make it smaller
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 16, 2015

@aashish24 @sankhesh @chaosphere2112 after the bots are done please review
goes with: CDAT/uvcdat-testdata#76

@@ -1214,6 +1214,7 @@ def prepGlyph(g, marker, index=0):
if t == 'dot':
gs.SetGlyphTypeToCircle()
gs.FilledOn()
s *= numpy.pi

This comment has been minimized.

@aashish24

aashish24 Oct 16, 2015

Contributor

Why not make it a integer number say 10, 20? it may help if we are going to do pixel align rendering.

This comment has been minimized.

@doutriaux1

doutriaux1 Oct 16, 2015

Member

I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.

This comment has been minimized.

@aashish24

aashish24 Oct 16, 2015

Contributor

I was looking at numbers with a scientist, 3 wasn't right and 4 too big. So I made it fun. Beside s is not an integer to start with.

I see. I am bit surprised that s is not an integer.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 16, 2015

other than that it LGTM 👍

aashish24 added a commit that referenced this pull request Oct 16, 2015

Merge pull request #1617 from UV-CDAT/issue_1281_bigger_dots
fix #1281 default marker size too small

@aashish24 aashish24 merged commit 6a4609c into master Oct 16, 2015

7 checks passed

cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Thu Oct 15 18:04:43 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Thu Oct 15 19:11:28 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Thu Oct 15 19:34:08 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Thu Oct 15 18:26:32 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Thu Oct 15 18:18:29 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the issue_1281_bigger_dots branch Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment