Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ESMF fail the build when fortran is the wrong version #1618

Merged
merged 2 commits into from Oct 16, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Oct 16, 2015

Does what it says on the tin.

message("[INFO] Skipping ESMF")
message("[INFO] gfortran version needs to be at least 4.3 to install ESMF")
message("[INFO] You have ${Fortran_VERSION}")
message(FATAL_ERROR "[ERROR] gfortran must be 4.3 < version < 5.0; you have ${Fortran_VERSION}")
Copy link
Contributor

@aashish24 aashish24 Oct 16, 2015

I think it should be

gfortran must be 4.3 <= version < 5.0

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 16, 2015

LGTM 👍

aashish24 added a commit that referenced this issue Oct 16, 2015
Made ESMF fail the build when fortran is the wrong version
@aashish24 aashish24 merged commit 3ccc90f into master Oct 16, 2015
5 of 7 checks passed
@aashish24 aashish24 deleted the warning_to_error_esmf_fortran branch Oct 16, 2015
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants