New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ESMF fail the build when fortran is the wrong version #1618

Merged
merged 2 commits into from Oct 16, 2015

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Oct 16, 2015

Does what it says on the tin.

message("[INFO] Skipping ESMF")
message("[INFO] gfortran version needs to be at least 4.3 to install ESMF")
message("[INFO] You have ${Fortran_VERSION}")
message(FATAL_ERROR "[ERROR] gfortran must be 4.3 < version < 5.0; you have ${Fortran_VERSION}")

This comment has been minimized.

@aashish24

aashish24 Oct 16, 2015

Contributor

I think it should be

gfortran must be 4.3 <= version < 5.0

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 16, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Oct 16, 2015

Merge pull request #1618 from UV-CDAT/warning_to_error_esmf_fortran
Made ESMF fail the build when fortran is the wrong version

@aashish24 aashish24 merged commit 3ccc90f into master Oct 16, 2015

5 of 7 checks passed

cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Fri Oct 16 15:55:38 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'In Queue: 1' (Fri Oct 16 14:57:41 2015)
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Fri Oct 16 15:17:13 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Fri Oct 16 16:17:46 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Fri Oct 16 15:44:16 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the warning_to_error_esmf_fortran branch Oct 16, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment