-
Notifications
You must be signed in to change notification settings - Fork 66
Fixed issue where XvsY was using the wrong element name #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apparently this applies to all 1D plots that are done via the canvas methods. I'm going to fix them all. |
Thanks Sam! From: Sam Fries <notifications@github.commailto:notifications@github.com> Apparently this applies to all 1D plots that are done via the canvas methods. I'm going to fix them all. — |
Looks like that's all of the ones in |
Ok should we make it exit nicely in that PR or should we create a separate issue for this? |
I think that should be in a separate issue; this one is pretty cut and dry. |
done at: #1622 |
@chaosphere2112 it seems to have broken: vcs_verify_remove_objects |
OK, so I tweaked how we store 1D objects in
|
Awesome! Thanks @chaosphere2112 |
@doutriaux1 Any idea what's up with the failed tests on crunchy? |
it says
probably need to restart |
@doutriaux1 @aashish24 So are we good to merge, then? |
@chaosphere2112 looks good to me if @doutriaux1 is okay with this change. 👍 |
@doutriaux1 @aashish24 ping |
Fixed issue where XvsY was using the wrong element name
Resolves issue #1620