New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uvcdat script now will redirect all output appropriately #1623

Merged
merged 4 commits into from Oct 22, 2015

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Oct 21, 2015

Fixes #1239; parses arguments passed to UV-CDAT, detects where output should be sent, and redirects all stdout and stderr to append at that location (in addition to the standard UV-CDAT logging mechanisms that are already printing at that point). Should fix the issues we've been having with miscellaneous C++ level logging getting dumped to the console (like the annoying Qt modal window non-error).

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

@chaosphere2112 as part of this PR could you please add documentation as well? Wiki for now should be good.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Oct 21, 2015

@aashish24 Documentation for what? The command line args we accept?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

@aashish24 Documentation for what? The command line args we accept?

Right.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

If it makes sense.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Oct 21, 2015

@aashish24 Well, they do get displayed if you do --help, but I can stick that onto the wiki.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

@chaosphere2112 thanks.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

@chaosphere2112 I meant for capture, target etc. as well but sounds like they are shown as well?

redirect=false
fi
;;
--output-std) redirect=false

This comment has been minimized.

@aashish24

aashish24 Oct 21, 2015

Contributor

is this mis-aligned?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 21, 2015

@chaosphere2112 looks good to me. I didn't run it myself. Just had one minor question.

Sam Fries added some commits Oct 21, 2015

Sam Fries
Sam Fries
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Oct 21, 2015

Ah, I misunderstood. Added some comments to the script to explain what everything does.

Sam Fries
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 22, 2015

thanks for taking care of it @chaosphere2112. LGTM 👍

aashish24 added a commit that referenced this pull request Oct 22, 2015

Merge pull request #1623 from UV-CDAT/redirect_all
uvcdat script now will redirect all output appropriately

@aashish24 aashish24 merged commit 7761f99 into master Oct 22, 2015

6 of 8 checks passed

cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Wed Oct 21 14:53:00 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'ctest -j4 -D Experimental' (Wed Oct 21 14:37:29 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'ctest -j4 -D Experimental' (Wed Oct 21 16:42:38 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Wed Oct 21 17:12:38 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Wed Oct 21 14:52:35 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the redirect_all branch Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment