uvcdat script now will redirect all output appropriately #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaosphere2112 as part of this PR could you please add documentation as well? Wiki for now should be good. |
|
@aashish24 Documentation for what? The command line args we accept? |
Right. |
|
If it makes sense. |
|
@aashish24 Well, they do get displayed if you do |
|
@chaosphere2112 thanks. |
|
@chaosphere2112 I meant for capture, target etc. as well but sounds like they are shown as well? |
| redirect=false | ||
| fi | ||
| ;; | ||
| --output-std) redirect=false |
|
@chaosphere2112 looks good to me. I didn't run it myself. Just had one minor question. |
added 2 commits
October 21, 2015 13:57
|
Ah, I misunderstood. Added some comments to the script to explain what everything does. |
|
thanks for taking care of it @chaosphere2112. LGTM 👍 |
aashish24
added a commit
that referenced
this pull request
Oct 22, 2015
uvcdat script now will redirect all output appropriately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239; parses arguments passed to UV-CDAT, detects where output should be sent, and redirects all stdout and stderr to append at that location (in addition to the standard UV-CDAT logging mechanisms that are already printing at that point). Should fix the issues we've been having with miscellaneous C++ level logging getting dumped to the console (like the annoying Qt modal window non-error).