Fix compilation on Ubuntu with gcc 5.2.1 #1647
Conversation
dnadeau4
changed the title
| @@ -37,11 +37,11 @@ endif() | |||
| if(CDAT_BUILD_ESMF_ESMP) | |||
| if("${CMAKE_Fortran_COMPILER_ID}" STREQUAL GNU) | |||
| # GNU gfortran must be >= 4.3 | |||
| if(${Fortran_MAJOR_VERSION} GREATER 3 AND ${Fortran_MINOR_VERSION} GREATER 2) | |||
| if(${Fortran_MAJOR_VERSION} GREATER 3 AND ${Fortran_MINOR_VERSION} GREATER 1) | |||
There was a problem hiding this comment.
That is odd, I thought @chaosphere2112 had made it so that we have to have less than 5, plus 4.0 would fail with this no?
There was a problem hiding this comment.
The previous required version was 4.3, which this would match.
There was a problem hiding this comment.
I confirm that this problem was present also in Debian (in my case in the current testing version). I have changed as explained,
CMake/cdat_modules/esmf_pkg.cmake
From
if(${Fortran_MAJOR_VERSION} GREATER 3 AND ${Fortran_MINOR_VERSION} GREATER 1)to
if(${Fortran_MAJOR_VERSION} GREATER 4 AND ${Fortran_MINOR_VERSION} GREATER 0)and the CMAKE seems to work.
|
I have a question about gfortran I think that needs to be cleaned up. Otherwise looks good to me. |
|
@dnadeau4 the patch wouldn't break the older GCC would it? |
|
Other than that, it looks good to me. 👍 thanks for pushing it. |
|
@dnadeau4 are you going to update it? with CMake version LESS ...of CMake.. |
|
I will when I get a chance. |
|
@aashish24 Done! |
|
@doutriaux1 can you take a look at the CMAKE version for gfortran. |
|
thanks @dnadeau4 on a quick look at it it looks good. I will have a closer look at it. |
|
@aashish24 since it's all CMake I will let you d the final merge, but it looks good. |
|
LGTM 👍 thanks @dnadeau4 |
Fix compilation on Ubuntu with gcc 5.2.1
testing if "ncurses" patch works on different machines.