Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue1549 durack1 update Matplotlib 1.4.3 to 1.5.0 #1652

Merged
merged 12 commits into from Nov 12, 2015

Conversation

@durack1
Copy link
Member

@durack1 durack1 commented Oct 31, 2015

Fix #1549 - Update Matplotlib 1.4.3 to 1.5.0

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 2, 2015

failed on RH6

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 2, 2015

@doutriaux1 looks like the matplotlib failure isn't the only one..

The following tests FAILED:
     88 - vcs_test_background_mode_rotate (Failed)
    515 - matplotlib_verify_import (Failed)
    516 - basemap_verify_import (Failed)

With matplotlib it seems like a package cycler isn't installed:

Successfully updated your environment to use UVCDAT
(changes are valid for this session/terminal only)
Version: 2.4.0.rc2-36-g1ed6144
Location: /export/doutriaux1/uvcbot/build/install
Traceback (most recent call last):
  File "/export/doutriaux1/uvcbot/uvcdat/testing/matplotlib/test_matplotlib_import.py", line 2, in <module>
    import matplotlib
  File "/export/doutriaux1/uvcbot/build/install/lib/python2.7/site-packages/matplotlib-1.5.0-py2.7-linux-x86_64.egg/matplotlib/__init__.py", line 124, in <module>
    from matplotlib.rcsetup import (defaultParams,
  File "/export/doutriaux1/uvcbot/build/install/lib/python2.7/site-packages/matplotlib-1.5.0-py2.7-linux-x86_64.egg/matplotlib/rcsetup.py", line 29, in <module>
    from cycler import Cycler, cycler as ccycler
ImportError: No module named cycler

I'll take another look at the matplotlib dependency list..

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 2, 2015

@doutriaux1 yep, looks like cycler is a required package I'll add it in..

Are the other dependencies also available: python, numpy (1.6+), dateutil (1.1+), pyparsing, libpng (1.2+), pytz, freetype (2.3+), cycler (0.9+)

It also ships with: agg 2.4, qhull 2012.1, ttconv, six 1.9.0 so there might be some duplication with existing source being built here.. The build order might matter..

set(CYCLER_MD5 c10ade5ca3f0aadf575eb25203b225a5)
set(CYCLER_SOURCE ${CYCLER_URL}/${CYCLER_GZ})

add_cdat_package_dependent(Cycler "" "" OFF "CDAT_BUILD_LEAN" OFF)
Copy link
Member Author

@durack1 durack1 Nov 2, 2015

@doutriaux1 not certain that this magic is correct - I used the template from Cython

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 2, 2015

@doutriaux1 do you know any reason why crunchy failed, yet oceanonly passed?

Is there a sync issue somewhere?

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 3, 2015

@doutriaux1 this is weird, why is crunchy failing - it seems to be out of sync with the PR..

It seems there's a pathspec error (error: pathspec 'issue1549_durack1_UpdateMatplotlib1.4.3To1.5.0' did not match any file(s) known to git.) - if this is related to git querying for a testdata branch, could some text be added to indicate this?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 4, 2015

no this error is normal it tries to find a matching baseline branch and it's an acceptable and expected failure in this case

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 4, 2015

@doutriaux1 any idea what's happening with Darwin-Mac2 10.10.5 (FULL)? It seems Cycler and Matplotlib installed fine, just the import went awry..

Successfully updated your environment to use UVCDAT
(changes are valid for this session/terminal only)
Version: 2.4.0.rc2-44-g68da209
Location: /Users/doutriaux1/bot/build/install
Traceback (most recent call last):
  File "/Users/doutriaux1/bot/uvcdat/testing/matplotlib/test_matplotlib_import.py", line 2, in <module>
    import matplotlib
ImportError: No module named matplotlib

On crunchy seems like the "normal" issues were reported:

The following tests FAILED:
     88 - vcs_test_background_mode_rotate (Failed)
    435 - vcs_addons_test_EzTemplate_12_plots_mix_glb_local (Failed)

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 4, 2015

@doutriaux1 wanna take a peek at this - I also think this PR is almost ready to go..

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 4, 2015

@jbeezley any idea what is going on with garant it seems it's failing a completely different set of tests..?

@jbeezley
Copy link

@jbeezley jbeezley commented Nov 4, 2015

It looks like there are some data files it isn't getting. I've seen this before, but I have no idea where the diags_test data comes from.

@jbeezley
Copy link

@jbeezley jbeezley commented Nov 4, 2015

The diags_test's were broken by #1615. The files are never downloaded and the directory that is supposed to contain them build/install/share does not exist.

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 4, 2015

@jbeezley I wonder why only garant was reporting this failure?

@jbeezley
Copy link

@jbeezley jbeezley commented Nov 4, 2015

Good question. I see this in the oceanonly build:

[INFO] Failed to fetch test data for uvcmetrics, tests will fail

It is a mystery how the tests are passing.

@jbeezley
Copy link

@jbeezley jbeezley commented Nov 4, 2015

It is executing a python script using the uvcdat python before it is built. Again, I have no idea why the LLNL builds are working unless the build directory is not getting deleted between builds.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 4, 2015

The build directories are being systematically deleted.

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 11, 2015

@doutriaux1 I think this is good to go

doutriaux1 added a commit that referenced this issue Nov 12, 2015
…lib1.4.3To1.5.0

issue1549 durack1 update Matplotlib 1.4.3 to 1.5.0
@doutriaux1 doutriaux1 merged commit fd8eb74 into master Nov 12, 2015
6 of 9 checks passed
@doutriaux1 doutriaux1 deleted the issue1549_durack1_UpdateMatplotlib1.4.3To1.5.0 branch Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants