Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ffmpeg root when building ffmpeg #1656

Merged
merged 1 commit into from Nov 10, 2015
Merged

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 2, 2015

No description provided.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 2, 2015

Ref: #1639

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 2, 2015

Requires this to be merged first: CDAT/VTK#12

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 2, 2015

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 2, 2015

@aashish24 both PR look good to me. But in order for the bots to pick this up we will need the VTK to be merged first. And @dnadeau4 has questions for you on CDAT/VTK#12

@aashish24 aashish24 force-pushed the vtk_fix_not_finding_ffmpeg branch from 28284ca to 69a5fc3 Nov 2, 2015
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 2, 2015

thanks @doutriaux1, I pushed a fix for the issue @dnadeau4 referred. It should be good now in VTK.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 2, 2015

ok once these are done I will retrigger

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 2, 2015

FYI: @doutriaux1 @dnadeau4 merged my VTK branch

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Nov 2, 2015

Let see if it passes.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 2, 2015

ok relaunched the request

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 3, 2015

@doutriaux1 looks like is good

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 3, 2015

@dnadeau4 it would be great if you can try this on the machine where you had the issue.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 6, 2015

@doutriaux1 I updated the branch with current master, once bots are done, please review.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 6, 2015

thx!

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 6, 2015

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 9, 2015

@doutriaux1 looks good to me..

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 9, 2015

I meant..the dashboard looks good to me..

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Nov 10, 2015

@doutriaux1 ping!

@@ -1,4 +1,4 @@
uvcdat
uv-cdat
Copy link
Contributor

@sankhesh sankhesh Nov 10, 2015

Shouldn't this be UV-CDAT?

Copy link
Contributor Author

@aashish24 aashish24 Nov 10, 2015

Shouldn't this be UV-CDAT?

this is not from my commit but rather came from Charle's merge. I am suspecting this is what we have in the master.

Copy link
Contributor Author

@aashish24 aashish24 Nov 10, 2015

I think @doutriaux1 did it to trigger build.. I will delete it.. thanks for finding it.

@aashish24 aashish24 force-pushed the vtk_fix_not_finding_ffmpeg branch from 0765698 to d5671e7 Nov 10, 2015
doutriaux1 added a commit that referenced this issue Nov 10, 2015
@doutriaux1 doutriaux1 merged commit 36697f8 into master Nov 10, 2015
7 of 9 checks passed
@doutriaux1 doutriaux1 deleted the vtk_fix_not_finding_ffmpeg branch Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants