Set ffmpeg root when building ffmpeg #1656
Conversation
|
Ref: #1639 |
|
Requires this to be merged first: CDAT/VTK#12 |
|
@aashish24 both PR look good to me. But in order for the bots to pick this up we will need the VTK to be merged first. And @dnadeau4 has questions for you on CDAT/VTK#12 |
aashish24
force-pushed
the
vtk_fix_not_finding_ffmpeg
branch
from
28284ca to
69a5fc3
Compare
|
thanks @doutriaux1, I pushed a fix for the issue @dnadeau4 referred. It should be good now in VTK. |
|
ok once these are done I will retrigger |
|
FYI: @doutriaux1 @dnadeau4 merged my VTK branch |
|
Let see if it passes. |
|
ok relaunched the request |
|
@doutriaux1 looks like is good |
|
@dnadeau4 it would be great if you can try this on the machine where you had the issue. |
|
@doutriaux1 I updated the branch with current master, once bots are done, please review. |
|
thx! |
|
@doutriaux1 looks good to me.. |
|
I meant..the dashboard looks good to me.. |
|
@doutriaux1 ping! |
README.md
Outdated
There was a problem hiding this comment.
Shouldn't this be UV-CDAT?
There was a problem hiding this comment.
Shouldn't this be UV-CDAT?
this is not from my commit but rather came from Charle's merge. I am suspecting this is what we have in the master.
There was a problem hiding this comment.
I think @doutriaux1 did it to trigger build.. I will delete it.. thanks for finding it.
aashish24
force-pushed
the
vtk_fix_not_finding_ffmpeg
branch
from
0765698 to
d5671e7
Compare
Set ffmpeg root when building ffmpeg
No description provided.