New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap again in update_input #1657

Merged
merged 6 commits into from Nov 16, 2015

Conversation

Projects
None yet
3 participants
@sankhesh
Contributor

sankhesh commented Nov 2, 2015

This change fixes the issue wherein no output was being produced
when animating projected data. Each draw_frame call invokes
VTKPlots::update_input which in turn calls doWrap on the
actor. Trying to wrap projected data fails.

Fixes #1086

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 2, 2015

@doutriaux1 @aashish24 Please review

Do not wrap data if it is projected
This change fixes the issue wherein no output was being produced
when animating projected data. Each draw_frame call invokes
VTKPlots::update_input which in turn calls doWrap on the
actor. Trying to wrap projected data fails.

Fixes #1086

@sankhesh sankhesh force-pushed the 1086_animation_bug branch from 33d725f to de8d649 Nov 2, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 3, 2015

@sankhesh this is great! Makes sense and LGTM 👍 Should we add a test for projected dataset animation as well?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 3, 2015

Yup. I can add one.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 6, 2015

@sankhesh can add one soon so that we can make it done?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 9, 2015

@sankhesh we should really get this one in master asap. Can you please add test soon?

Thanks,

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 10, 2015

Baselines added in CDAT/uvcdat-testdata#81

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 10, 2015

@doutriaux1 While adding the test for this issue, I found that meshfill plots with mercator projection fails. Documented here: #1671

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 11, 2015

Not sure why we have those test failures. They don't fail on my machine.
@aashish24 @doutriaux1 Can you reproduce those failures?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 11, 2015

@sankhesh which machine you are seeing these failures?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 11, 2015

annie, crunchy

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 12, 2015

@sankhesh both annie and crunchy are running behind Xvfb. Can you try with Xvfb?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 13, 2015

@sankhesh any luck with testing?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 13, 2015

@aashish24 I've pushed a new change to test only the last image of the animation as you suggested. Waiting on the dashboards to complete.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 13, 2015

thanks @sankhesh much appreciated!

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 16, 2015

@doutriaux1 @chaosphere2112 This branch is ready to be merged. The build errors are not from this branch. The only true error is meshfill_mercator animation which will be fixed by #1672

doutriaux1 added a commit that referenced this pull request Nov 16, 2015

Merge pull request #1657 from UV-CDAT/1086_animation_bug
Do not wrap again in update_input

@doutriaux1 doutriaux1 merged commit 91198b1 into master Nov 16, 2015

1 of 9 checks passed

cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'make -j4' (Mon Nov 16 09:49:35 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'make -j4' (Mon Nov 16 09:51:28 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'make -j4' (Mon Nov 16 09:50:15 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Mon Nov 16 10:32:31 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'In Queue: 1' (Mon Nov 16 09:37:55 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'In Queue: 2' (Mon Nov 16 09:37:49 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the 1086_animation_bug branch Nov 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment