load texttables and textorientations and text markers first #1658
Conversation
|
@doutriaux1 looks like |
some gm and templates use these
vcs.elements is now an ordered dict initial.attribute removed all UV templates that are now in metrics repo loading if initial.attributes done at import vcs time rather than x.init()
doutriaux1
force-pushed
the
load_vcs_dependencies_right_order_from_json
branch
from
01a1bdd
to
2a38096
Compare
|
@doutriaux1 you said quick review...I see lot of changes? |
|
yes that was before I went crazy 😉 I still need to push fix for one test I think |
|
goes with: CDAT/uvcdat-testdata#78 |
|
@aashish24 seems like all tests are passing now. Ready for review. |
|
Will do today..thanks :) |
|
LGTM 👍 |
…er_from_json load texttables and textorientations and text markers first
|
@doutriaux1 @durack1 Uh, this seems to have slipped in ipython 4.0, which has a busted build. |
|
@chaosphere2112 that's weird, @doutriaux1 reverted the |
|
@chaosphere2112 the PR on hold for |
|
@durack1 yeah, but it looks like @doutriaux1 accidentally merged #1675 into this branch (if you look above, there's 683596c in this PR. Just found out when I did a full build from source and typed "ipython" and it choked and died. |
some gm and templates use these
@aashish24 @chaosphere2112 @sankhesh should be a quick review