Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window flickering when png #1667

Merged
merged 6 commits into from Nov 12, 2015
Merged

Window flickering when png #1667

merged 6 commits into from Nov 12, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 9, 2015

@aashish24 @chaosphere2112 @sankhesh

@doutriaux1 doutriaux1 added the Bug label Nov 9, 2015
@doutriaux1 doutriaux1 added this to the 2.4 milestone Nov 9, 2015
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Nov 9, 2015

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Nov 10, 2015

@aashish24 @jbeezley @sankhesh I'm not sure what happened on the macbot1 ?

@@ -4912,7 +4913,7 @@ def isopened(self):
"""Is the Canvas opened?"""
return self.backend.isopened()

def _compute_width_height(self, width, height, units, ps=True):
def _compute_width_height(self, width, height, units, ps=False):
Copy link
Contributor

@aashish24 aashish24 Nov 10, 2015

Why false now?

Copy link
Contributor Author

@doutriaux1 doutriaux1 Nov 10, 2015

This was only for postscript.

anims are taking care of it already anyway
anims rescale to W/H +1 rather than -1 in the odd case user would send a 1x1 pix
flake8ed
@doutriaux1 doutriaux1 force-pushed the window_flickering_when_png branch from fd497b0 to 158aee8 Nov 10, 2015
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Nov 12, 2015

@aashish24 ping

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 12, 2015

@doutriaux1 changes looks good to me 👍 we can clean up lastSize stuff afterwards (this was anyways exists currently).

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Nov 12, 2015

great! Feel free to merge 😉

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 12, 2015

LGTM merging

aashish24 added a commit that referenced this issue Nov 12, 2015
@aashish24 aashish24 merged commit 7ce7fc7 into master Nov 12, 2015
5 of 9 checks passed
@aashish24 aashish24 deleted the window_flickering_when_png branch Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants