New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window flickering when png #1667

Merged
merged 6 commits into from Nov 12, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Nov 9, 2015

doutriaux1 added some commits Nov 9, 2015

force a configureEven in png after resizing
dont go to ps if not coming from ps in _compute_width

@doutriaux1 doutriaux1 added the Bug label Nov 9, 2015

@doutriaux1 doutriaux1 added this to the 2.4 milestone Nov 9, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 9, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 10, 2015

@aashish24 @jbeezley @sankhesh I'm not sure what happened on the macbot1 ?

@@ -4912,7 +4913,7 @@ def isopened(self):
"""Is the Canvas opened?"""
return self.backend.isopened()
def _compute_width_height(self, width, height, units, ps=True):
def _compute_width_height(self, width, height, units, ps=False):

This comment has been minimized.

@aashish24

aashish24 Nov 10, 2015

Contributor

Why false now?

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 10, 2015

Member

This was only for postscript.

@@ -5018,7 +5021,7 @@ def postscript(self, file, mode='r', orientation=None, width=None, height=None,
# figures out width/height
W, H = self._compute_width_height(
width, height, units)
width, height, units, ps=True)

This comment has been minimized.

@aashish24

aashish24 Nov 10, 2015

Contributor

I see. so we treat ps as a special case..

This comment has been minimized.

@doutriaux1

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 10, 2015

Member

That was actually the reason for the flickering, it was going through that bit and changed the size

# Gets user physical screen dimensions
if isinstance(width,int) and isinstance(height,int):

This comment has been minimized.

@aashish24

aashish24 Nov 10, 2015

Contributor

space between width, and int please 😢

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 10, 2015

Member

Yes I always forget to run flake8, will push changes for flake8 soon.

@@ -458,6 +465,7 @@ def isopened(self):
def geometry(self, x, y, *args):
self.renWin.SetSize(x, y)
self._lastSize = (x, y)

This comment has been minimized.

@aashish24

aashish24 Nov 10, 2015

Contributor

why we are storing lastSize?

This comment has been minimized.

@aashish24

aashish24 Nov 10, 2015

Contributor

I know in the past there was an issue with vistrails. Is that still true? I would rather prefer not to have this convoluted logic behind previous and the current size if possible.

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 10, 2015

Member

I'm not sure but since we do it everywhere else where the size changes I added it as well. @chaosphere2112 do we still need this when we switch to your GUI

the %2 bit was breaking all baselines
anims are taking care of it already anyway
anims rescale to W/H +1 rather than -1 in the odd case user would send a 1x1 pix
flake8ed

@doutriaux1 doutriaux1 force-pushed the window_flickering_when_png branch from fd497b0 to 158aee8 Nov 10, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 12, 2015

@aashish24 ping

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 12, 2015

@doutriaux1 changes looks good to me 👍 we can clean up lastSize stuff afterwards (this was anyways exists currently).

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 12, 2015

great! Feel free to merge 😉

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 12, 2015

LGTM merging

aashish24 added a commit that referenced this pull request Nov 12, 2015

@aashish24 aashish24 merged commit 7ce7fc7 into master Nov 12, 2015

5 of 9 checks passed

cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'make -j4' (Tue Nov 10 14:20:45 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Tue Nov 10 14:00:45 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'In Queue: 6' (Tue Nov 10 13:32:28 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Tue Nov 10 17:37:04 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Tue Nov 10 14:50:11 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Tue Nov 10 14:09:30 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the window_flickering_when_png branch Nov 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment