Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1263 durack1 Fix Travis OS X pyexpat build error #1674

Merged
merged 2 commits into from Nov 12, 2015

Conversation

@durack1
Copy link
Member

@durack1 durack1 commented Nov 11, 2015

Fix #1263 - Travis OS X pyexpat build error - build against system expat

@aashish24 @doutriaux1 please review and merge - this will fix the travis OS X build errors, but it's a kludge as the expat build errors are likely an artifact of problems with the build environment not being set up correctly - when running a Python 2.7.10 build (which includes expat and pyexpat) this completes successfully with no warnings outside of the cmake build command - take a peek at PCMDI/pcmdi_metrics#285 for more info.. PCMDI/pcmdi_metrics#279 was the issue that triggered this PR

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 11, 2015

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 12, 2015

@aashish24 @jbeezley this is the PR that @doutriaux1 wanted you folks to take a look at..

@@ -10,8 +10,6 @@ before_install:
- if [ "$TRAVIS_OS_NAME" = "osx" ]; then brew update ; brew outdated cmake || brew upgrade cmake ; fi
- cmake --version

before_script: travis_wait
Copy link
Contributor

@aashish24 aashish24 Nov 12, 2015

@jbeezley did you add this line?

Copy link
Member Author

@durack1 durack1 Nov 12, 2015

@aashish24 nope that was me - and it's redundant and did nothing.. For it to work to extend timeouts it needs to precede the command line arguments

@durack1
Copy link
Member Author

@durack1 durack1 commented Nov 12, 2015

@aashish24 any luck with reviewing this/figuring out what was/is happening? We're waiting on the PR to be merged so we can fix the downstream issue at PCMDI/pcmdi_metrics#279 along with some other fixes in the queue..

doutriaux1 added a commit that referenced this issue Nov 12, 2015
…yexpatBuildError

Issue1263 durack1 Fix Travis OS X pyexpat build error
@doutriaux1 doutriaux1 merged commit 709468c into master Nov 12, 2015
3 of 9 checks passed
@doutriaux1 doutriaux1 deleted the issue1263_durack1_FixTravisOSXPyexpatBuildError branch Nov 12, 2015
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 13, 2015

thanks @durack1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants