Conversation
|
@chaosphere2112 This branch is ready to be merged. I can remove the code duplication in a separate branch once #1678 is merged. Lets not hold this back. |
|
🔔 Ping! |
|
@sankhesh this branch needs to be updated as it has merge conflict.. |
|
@sankhesh I would like to merge this branch AFTER the colormaps one, as I think it will be easier to merge potential breakage that way. |
Conflicts: Packages/vcs/Lib/vcsvtk/isolinepipeline.py
Conflicts: Packages/vcs/Lib/vcsvtk/isolinepipeline.py
|
@doutriaux1 This branch is ready for merge. The failures are because I did not merge your |
|
Please make sure to merge #1693 before merging this branch. |
8602a82 to
7fc56e3
Compare
|
Re-triggered builds with new baselines. |
|
Rh full issues are xfvb related. I probably need to restart it. Rh mesa passes. Will wait for a Mac and merge in |
|
@sankesh will update thrshold on your test failing on Ubuntu 15.10 before merging in if macs come out ok |
|
@doutriaux1 so this would be our last PR for now? |
|
@aashish24 yes, but stipple test fails. What do you prefer try with a new baseline? Or increase threshold and merge? |
|
@doutriaux1 I looked at the differences and to me it seems to be system specific changes and not that the code is buggy. I would suggest increase the threshold and merge. |
|
@sankhesh can you increase the threshold? |
|
@sankhesh @aashish24 Yeah, I had to up the threshold for my stipple test. |
This allows platform specific differences between test and baseline images. This change fixes issues on machines using XfVb.
|
Done. |
|
thanks @sankhesh |
Fixes #1625