Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add the ability to write/read PNG metadata #1689

Merged
merged 1 commit into from Nov 16, 2015
Merged

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Nov 13, 2015

Canvas.png now has an extra parameter 'metadata' which is
a dictionary with key,value pairs to be written to the PNG file.
We added a new function vcs.png_read_metadata which returns
a dictionary of key,value pairs read from the PNG file.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Nov 13, 2015

@aashish24 @sankhesh Please review.

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Nov 13, 2015

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 13, 2015

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 13, 2015

@danlipsa some tests failed

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 13, 2015

Dan vcs_test_png_metadata failed because VTK branch was merged afterwards. I merged it now so when you update this branch to fix the flake8_vcs failing test, it should pass.

Canvas.png now has an extra parameter 'metadata' which is
a dictionary with key,value pairs to be written to the PNG file.
We added a new function vcs.png_read_metadata which returns
a dictionary of key,value pairs read from the PNG file.
@danlipsa danlipsa force-pushed the png-add-text-chunks branch from 81403fb to af562c5 Nov 16, 2015
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Nov 16, 2015

@danlipsa funny, I pulled your branch, merged master in it to re-trigger a build and I push I get a conflict, you had synchronized the branch in the 30seconds in between... Anyhow let's see what the bots say (probably failure on macs but unrelated) and let's merge this.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Nov 16, 2015

Yes, I just pushed another SHA which included Aashish's style fix. Indeed let's wait for the tests to complete.

doutriaux1 added a commit that referenced this issue Nov 16, 2015
ENH: Add the ability to write/read PNG metadata
@doutriaux1 doutriaux1 merged commit d19685e into master Nov 16, 2015
3 of 9 checks passed
@doutriaux1 doutriaux1 deleted the png-add-text-chunks branch Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants