New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add the ability to write/read PNG metadata #1689

Merged
merged 1 commit into from Nov 16, 2015

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Nov 13, 2015

Canvas.png now has an extra parameter 'metadata' which is
a dictionary with key,value pairs to be written to the PNG file.
We added a new function vcs.png_read_metadata which returns
a dictionary of key,value pairs read from the PNG file.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Nov 13, 2015

@aashish24 @sankhesh Please review.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Nov 13, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 13, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 13, 2015

@danlipsa some tests failed

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 13, 2015

Dan vcs_test_png_metadata failed because VTK branch was merged afterwards. I merged it now so when you update this branch to fix the flake8_vcs failing test, it should pass.

ENH: Add the ability to write/read PNG metadata
Canvas.png now has an extra parameter 'metadata' which is
a dictionary with key,value pairs to be written to the PNG file.
We added a new function vcs.png_read_metadata which returns
a dictionary of key,value pairs read from the PNG file.

@danlipsa danlipsa force-pushed the png-add-text-chunks branch from 81403fb to af562c5 Nov 16, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 16, 2015

@danlipsa funny, I pulled your branch, merged master in it to re-trigger a build and I push I get a conflict, you had synchronized the branch in the 30seconds in between... Anyhow let's see what the bots say (probably failure on macs but unrelated) and let's merge this.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Nov 16, 2015

Yes, I just pushed another SHA which included Aashish's style fix. Indeed let's wait for the tests to complete.

doutriaux1 added a commit that referenced this pull request Nov 16, 2015

Merge pull request #1689 from UV-CDAT/png-add-text-chunks
ENH: Add the ability to write/read PNG metadata

@doutriaux1 doutriaux1 merged commit d19685e into master Nov 16, 2015

3 of 9 checks passed

cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'make -j4' (Mon Nov 16 12:13:40 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'make -j4' (Mon Nov 16 12:14:24 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'make -j4' (Mon Nov 16 12:16:37 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'In Queue: 2' (Mon Nov 16 12:04:15 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'In Queue: 3' (Mon Nov 16 12:04:13 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Mon Nov 16 12:52:49 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the png-add-text-chunks branch Nov 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment