ENH: Add the ability to write/read PNG metadata #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashish24 @sankhesh Please review. |
|
Cool! thanks @sankhesh @danlipsa Ping @isubsmith @williams13 |
|
@danlipsa some tests failed |
|
Dan vcs_test_png_metadata failed because VTK branch was merged afterwards. I merged it now so when you update this branch to fix the flake8_vcs failing test, it should pass. |
Canvas.png now has an extra parameter 'metadata' which is a dictionary with key,value pairs to be written to the PNG file. We added a new function vcs.png_read_metadata which returns a dictionary of key,value pairs read from the PNG file.
danlipsa
force-pushed
the
png-add-text-chunks
branch
from
81403fb
to
af562c5
Compare
|
@danlipsa funny, I pulled your branch, merged master in it to re-trigger a build and I push I get a conflict, you had synchronized the branch in the 30seconds in between... Anyhow let's see what the bots say (probably failure on macs but unrelated) and let's merge this. |
|
Yes, I just pushed another SHA which included Aashish's style fix. Indeed let's wait for the tests to complete. |
doutriaux1
added a commit
that referenced
this pull request
Nov 16, 2015
ENH: Add the ability to write/read PNG metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canvas.png now has an extra parameter 'metadata' which is
a dictionary with key,value pairs to be written to the PNG file.
We added a new function vcs.png_read_metadata which returns
a dictionary of key,value pairs read from the PNG file.