Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure arguments separator #1692

Merged
merged 3 commits into from Nov 16, 2015
Merged

fix configure arguments separator #1692

merged 3 commits into from Nov 16, 2015

Conversation

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Nov 14, 2015

+set(readline_conf_args "--with-curses;--disable-static;--enable-shared")

@@ -2,7 +2,7 @@ set(readline_source "${CMAKE_CURRENT_BINARY_DIR}/build/readline")
set(readline_install "${cdat_EXTERNALS}")
set(readline_conf_args)

set(readline_conf_args "--with-curses --disable-static --enable-shared")
set(readline_conf_args "--with-curses\;--disable-static\;--enable-shared")
Copy link
Contributor

@aashish24 aashish24 Nov 14, 2015

you don't need to use backslash here..

Copy link
Contributor Author

@dnadeau4 dnadeau4 Nov 15, 2015

When I compile with a "space" cmake fails on my Ubuntu machine at home. I tried "^^" and it failed also, I will take away the backspace, but we should be consistent. in ffmpeg_external.cmake the arguments are set to "^^".

doutriaux1 added a commit that referenced this issue Nov 16, 2015
fix configure arguments separator
@doutriaux1 doutriaux1 merged commit efcf3c2 into master Nov 16, 2015
4 of 9 checks passed
@doutriaux1 doutriaux1 deleted the readlineconfig branch Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants