New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure arguments separator #1692

Merged
merged 3 commits into from Nov 16, 2015

Conversation

Projects
None yet
3 participants
@dnadeau4
Contributor

dnadeau4 commented Nov 14, 2015

+set(readline_conf_args "--with-curses;--disable-static;--enable-shared")

@@ -2,7 +2,7 @@ set(readline_source "${CMAKE_CURRENT_BINARY_DIR}/build/readline")
set(readline_install "${cdat_EXTERNALS}")
set(readline_conf_args)

set(readline_conf_args "--with-curses --disable-static --enable-shared")
set(readline_conf_args "--with-curses\;--disable-static\;--enable-shared")

This comment has been minimized.

@aashish24

aashish24 Nov 14, 2015

Contributor

you don't need to use backslash here..

This comment has been minimized.

@dnadeau4

dnadeau4 Nov 15, 2015

Contributor

When I compile with a "space" cmake fails on my Ubuntu machine at home. I tried "^^" and it failed also, I will take away the backspace, but we should be consistent. in ffmpeg_external.cmake the arguments are set to "^^".

dnadeau4 added some commits Nov 15, 2015

doutriaux1 added a commit that referenced this pull request Nov 16, 2015

Merge pull request #1692 from UV-CDAT/readlineconfig
fix configure arguments separator

@doutriaux1 doutriaux1 merged commit efcf3c2 into master Nov 16, 2015

4 of 9 checks passed

cont-int/LLNL/Darwin-Mac 10.10.5 (LEAN) running 'make -j4' (Sat Nov 14 21:14:42 2015)
Details
cont-int/LLNL/Darwin-Mac1 10.10.5 (NOGUI) running 'make -j4' (Sat Nov 14 21:20:48 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'make -j4' (Sat Nov 14 21:19:56 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'In Queue: 6' (Sat Nov 14 21:07:47 2015)
Details
cont-int/LLNL/Linux-annie Ubuntu 15.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Sat Nov 14 21:56:51 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Sat Nov 14 21:33:57 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the readlineconfig branch Nov 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment