Altered some tests to ensure geometry #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @chaosphere2112 for taking care of this quickly! |
|
@aashish24 @doutriaux1 @jbeezley So, this is what's busted still. The PNG is coming out in the correct dimensions now, but the labels are all wrong and the plot is misshapen. |
|
@doutriaux1 @aashish24 Seems to have finally passed |
|
It did it!! 👍 LGTM Thanks @chaosphere2112 this is awesome. |
aashish24
added a commit
that referenced
this pull request
Nov 19, 2015
Altered some tests to ensure geometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully fix issues that garant and @doutriaux1 have been having with automatic window sizing and some tests.