Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered some tests to ensure geometry #1697

Merged
merged 3 commits into from Nov 19, 2015
Merged

Altered some tests to ensure geometry #1697

merged 3 commits into from Nov 19, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Nov 18, 2015

Should hopefully fix issues that garant and @doutriaux1 have been having with automatic window sizing and some tests.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 18, 2015

thanks @chaosphere2112 for taking care of this quickly!

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Nov 18, 2015
@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Nov 18, 2015

@aashish24 @doutriaux1 @jbeezley So, this is what's busted still. The PNG is coming out in the correct dimensions now, but the labels are all wrong and the plot is misshapen.

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Nov 19, 2015

@doutriaux1 @aashish24 Seems to have finally passed test_vcs_click_info on garant!

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 19, 2015

It did it!! 👍 LGTM Thanks @chaosphere2112 this is awesome.

aashish24 added a commit that referenced this issue Nov 19, 2015
Altered some tests to ensure geometry
@aashish24 aashish24 merged commit 72e4d69 into master Nov 19, 2015
3 of 8 checks passed
@aashish24 aashish24 deleted the fix_res_dependent_tests branch Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants