New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue where old scr colormap file would not load opacity #1699

Merged
merged 2 commits into from Nov 23, 2015

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Nov 19, 2015

@aashish24 @sankhesh @chaosphere2112 just found a tiny bug. Please merge.

@@ -33,7 +33,7 @@ def process_src(nm, code):
for i in range(255):
val = numbers[i * 3:i * 3 + 3]
if val != ():
d[i] = list(val)
d[i] = list(val)+[100]

This comment has been minimized.

@aashish24

aashish24 Nov 19, 2015

Contributor

@doutriaux1 can you exaplain bit more what this code is doing?

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 19, 2015

Member

old colormaps only had r,g,b values so when loading back in it only stores 3 values, then later on when using getcolor we unpack it into r,g,b,a causing a failure. Voila.

This comment has been minimized.

@sankhesh

sankhesh Nov 19, 2015

Contributor

Not Flake8 compliant.

Need spaces around binary operator "+".

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 20, 2015

Member

yet flake8 passes, bwwwaaaaaa I beat flake8!!!!!

Update colormap.py
fixes bug where flake8 does not see that the syntax was wrong and make @aashish24 and @sankhesh happy.
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 23, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Nov 23, 2015

Merge pull request #1699 from UV-CDAT/load_colormap_old_style_transpa…
…rency_issue

fixed issue where old scr colormap file would not load opacity

@aashish24 aashish24 merged commit f89af2f into master Nov 23, 2015

2 of 9 checks passed

cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Thu Nov 19 19:01:07 2015)
Details
cont-int/LLNL/Darwin-Mac LEAN running 'make -j4' (Thu Nov 19 16:50:33 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'make -j4' (Thu Nov 19 19:11:55 2015)
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j12 -D Experimental' (Sat Nov 21 05:32:34 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Thu Nov 19 17:15:38 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Thu Nov 19 18:09:03 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the load_colormap_old_style_transparency_issue branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment