Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue where old scr colormap file would not load opacity #1699

Merged
merged 2 commits into from
Nov 23, 2015

Conversation

doutriaux1
Copy link
Contributor

@aashish24 @sankhesh @chaosphere2112 just found a tiny bug. Please merge.

@@ -33,7 +33,7 @@ def process_src(nm, code):
for i in range(255):
val = numbers[i * 3:i * 3 + 3]
if val != ():
d[i] = list(val)
d[i] = list(val)+[100]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 can you exaplain bit more what this code is doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old colormaps only had r,g,b values so when loading back in it only stores 3 values, then later on when using getcolor we unpack it into r,g,b,a causing a failure. Voila.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Flake8 compliant.

Need spaces around binary operator "+".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet flake8 passes, bwwwaaaaaa I beat flake8!!!!!

fixes bug where flake8 does not see that the syntax was wrong and make @aashish24 and @sankhesh happy.
@aashish24
Copy link
Contributor

LGTM 👍

aashish24 added a commit that referenced this pull request Nov 23, 2015
…rency_issue

fixed issue where old scr colormap file would not load opacity
@aashish24 aashish24 merged commit f89af2f into master Nov 23, 2015
@aashish24 aashish24 deleted the load_colormap_old_style_transparency_issue branch November 23, 2015 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants