Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial size #1709

Merged
merged 5 commits into from Dec 1, 2015
Merged

Fix initial size #1709

merged 5 commits into from Dec 1, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Nov 25, 2015

Added a test for initial sizing of window (you can pass a geometry kwarg to vcs.init to specify window dimensions), and fixed some issues with the logic. Also tests to make sure open(width=X, height=X) works properly.

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Nov 25, 2015
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 28, 2015

@chaosphere2112 flake8_vcs is failing..

@aashish24 aashish24 closed this Nov 28, 2015
@aashish24 aashish24 reopened this Nov 28, 2015
fix flake8?
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 30, 2015

@chaosphere2112 @doutriaux1 lot of tests are failing on Linux-RH6. Looking into it.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Nov 30, 2015

@doutriaux1 could it be because of VTK SHA (wrong one)

if "width" in kargs and kargs["width"] is not None:
width = kargs["width"]
if "height" in kargs and kargs["height"] is not None:
height = kargs["height"]
Copy link
Contributor

@doutriaux1 doutriaux1 Nov 30, 2015

that's essentially what the old code was doing, why the more complicated lines?

Copy link
Contributor Author

@chaosphere2112 chaosphere2112 Nov 30, 2015

Because width and height are always passed into this function by the caller, though most of the time they are None.

Copy link
Contributor

@doutriaux1 doutriaux1 Nov 30, 2015

I see, thx

doutriaux1 added a commit that referenced this issue Dec 1, 2015
@doutriaux1 doutriaux1 merged commit f841c76 into master Dec 1, 2015
3 of 9 checks passed
@chaosphere2112 chaosphere2112 deleted the fix_initial_size branch Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants