New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial size #1709

Merged
merged 5 commits into from Dec 1, 2015

Conversation

Projects
None yet
3 participants
@chaosphere2112
Contributor

chaosphere2112 commented Nov 25, 2015

Added a test for initial sizing of window (you can pass a geometry kwarg to vcs.init to specify window dimensions), and fixed some issues with the logic. Also tests to make sure open(width=X, height=X) works properly.

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Nov 25, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 28, 2015

@chaosphere2112 flake8_vcs is failing..

@aashish24 aashish24 closed this Nov 28, 2015

@aashish24 aashish24 reopened this Nov 28, 2015

Update Canvas.py
fix flake8?
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 30, 2015

@chaosphere2112 @doutriaux1 lot of tests are failing on Linux-RH6. Looking into it.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 30, 2015

@doutriaux1 could it be because of VTK SHA (wrong one)

if "width" in kargs and kargs["width"] is not None:
width = kargs["width"]
if "height" in kargs and kargs["height"] is not None:
height = kargs["height"]

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 30, 2015

Member

that's essentially what the old code was doing, why the more complicated lines?

This comment has been minimized.

@chaosphere2112

chaosphere2112 Nov 30, 2015

Contributor

Because width and height are always passed into this function by the caller, though most of the time they are None.

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 30, 2015

Member

I see, thx

@@ -860,7 +860,7 @@ def objecthelp(self, *arg):
# #
##########################################################################
def __init__(self, gui=0, mode=1, pause_time=0,
call_from_gui=0, size=None, backend="vtk", geometry=None):
call_from_gui=0, size=None, backend="vtk", geometry=None, bg=None):

This comment has been minimized.

@doutriaux1

doutriaux1 Nov 30, 2015

Member

is that bg used anywhere?

This comment has been minimized.

@chaosphere2112

chaosphere2112 Nov 30, 2015

Contributor

bg makes it so you can call open without displaying the canvas. I use it in the test I added (down at the bottom), to make it so this test doesn't flash on the screen (which I know you hate 😉). I believe I can also use it to fully background-ize a couple of the other tests I've added that flash on the screen.

Sam Fries

doutriaux1 added a commit that referenced this pull request Dec 1, 2015

@doutriaux1 doutriaux1 merged commit f841c76 into master Dec 1, 2015

3 of 9 checks passed

cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Mon Nov 30 16:22:56 2015)
Details
cont-int/LLNL/Darwin-Mac2 10.10.5 (FULL) running 'ctest -j4 -D Experimental' (Mon Nov 30 17:05:52 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Mon Nov 30 14:52:58 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Mon Nov 30 15:24:33 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j12 -D Experimental' (Tue Dec 1 08:42:34 2015)
Details
cont-int/LLNL/Darwin-Mac LEAN running 'ctest -j4 -D Experimental' (Mon Nov 30 14:39:05 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@chaosphere2112 chaosphere2112 deleted the fix_initial_size branch Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment