Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial size #1709

Merged
merged 5 commits into from
Dec 1, 2015
Merged

Fix initial size #1709

merged 5 commits into from
Dec 1, 2015

Conversation

chaosphere2112
Copy link
Contributor

Added a test for initial sizing of window (you can pass a geometry kwarg to vcs.init to specify window dimensions), and fixed some issues with the logic. Also tests to make sure open(width=X, height=X) works properly.

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Nov 25, 2015
@aashish24
Copy link
Contributor

@chaosphere2112 flake8_vcs is failing..

@aashish24 aashish24 closed this Nov 28, 2015
@aashish24 aashish24 reopened this Nov 28, 2015
fix flake8?
@aashish24
Copy link
Contributor

@chaosphere2112 @doutriaux1 lot of tests are failing on Linux-RH6. Looking into it.

@aashish24
Copy link
Contributor

@doutriaux1 could it be because of VTK SHA (wrong one)

if "width" in kargs and kargs["width"] is not None:
width = kargs["width"]
if "height" in kargs and kargs["height"] is not None:
height = kargs["height"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's essentially what the old code was doing, why the more complicated lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because width and height are always passed into this function by the caller, though most of the time they are None.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thx

doutriaux1 added a commit that referenced this pull request Dec 1, 2015
@doutriaux1 doutriaux1 merged commit f841c76 into master Dec 1, 2015
@chaosphere2112 chaosphere2112 deleted the fix_initial_size branch February 12, 2016 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants