Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs with continents line #1712

Merged
merged 1 commit into from Dec 1, 2015
Merged

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Nov 30, 2015

  • Colors weren't being properly normalized; this has been fixed.
  • Alpha is now respected
  • Made error handling more robust for weird input (if someone passes in a float, it'll get converted into an int then used as an index into a colormap instead of blowing up).
@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Dec 1, 2015
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 1, 2015

Looks correct to me..

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 1, 2015

LGTM 👍

aashish24 added a commit that referenced this issue Dec 1, 2015
@aashish24 aashish24 merged commit 6fc6721 into master Dec 1, 2015
3 of 8 checks passed
@aashish24 aashish24 deleted the fix_continents_line_color branch Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants