Fixed some bugs with continents line #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chaosphere2112
commented
Nov 30, 2015
chaosphere2112
commented
- Colors weren't being properly normalized; this has been fixed.
- Alpha is now respected
- Made error handling more robust for weird input (if someone passes in a float, it'll get converted into an int then used as an index into a colormap instead of blowing up).
|
Looks correct to me.. |
|
LGTM 👍 |
aashish24
added a commit
that referenced
this pull request
Dec 1, 2015
Fixed some bugs with continents line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.