New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue #1106: Continents are off. #1717

Merged
merged 2 commits into from Dec 10, 2015

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Dec 2, 2015

The fix for this issue is at 658ac44.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 2, 2015

import sys
import vcs
pth = os.path.join(os.path.dirname(__file__),"..")

This comment has been minimized.

@sankhesh

sankhesh Dec 2, 2015

Contributor

@danlipsa It would be good if new code followed PEP8 convention.

In this case, there should be a space after the comma.

This comment has been minimized.

@doutriaux1

doutriaux1 Dec 2, 2015

Member

the pep8 police 😉 I'm with you @danlipsa "vive la resistance"

This comment has been minimized.

@sankhesh

sankhesh Dec 2, 2015

Contributor

@aashish24 Lets crush the resistance. 💣

#gm = x.createisofill()
#gm.label = "y"
gm = x.createboxfill()
gm.boxfill_type="custom"

This comment has been minimized.

@sankhesh

sankhesh Dec 2, 2015

Contributor

Spaces around =

f=cdms2.open(sys.argv[2])
ice = f("variable_6")
x=vcs.init()

This comment has been minimized.

@doutriaux1

doutriaux1 Dec 2, 2015

Member

@danlipsa please add the bit to turn off antialiasing and increase the background size, also turn off logo. Thanks

Add test for issue #1106: Continents are off.
The fix for this issue is at 658ac44.

@danlipsa danlipsa force-pushed the continents-off-test branch from a94f4fa to ce8956a Dec 2, 2015

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 2, 2015

@sankhesh @doutriaux1 I have addressed all comments.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 3, 2015

thx @danlipsa did you also update the baseline with the not antialiased pix?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 3, 2015

@doutriaux1 does n't look like it. I am going to upload a new baseline.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 3, 2015

@doutriaux1 @aashish24 I did upload the larger file, which I think is also not antialiased.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 4, 2015

@doutriaux1 @aashish24 is this ready?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 10, 2015

@aashish24 @doutriaux1 Can we merge this?

doutriaux1 added a commit that referenced this pull request Dec 10, 2015

Merge pull request #1717 from UV-CDAT/continents-off-test
Add test for issue #1106: Continents are off.

@doutriaux1 doutriaux1 merged commit 8087cd0 into master Dec 10, 2015

3 of 8 checks passed

cont-int/LLNL/Darwin-Mac (FULL) running 'make -j4' (Thu Dec 10 09:55:46 2015)
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'In Queue: 2' (Thu Dec 10 08:32:15 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'In Queue: 4' (Thu Dec 10 08:32:05 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'In Queue: 4' (Thu Dec 10 08:32:16 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build started
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Thu Dec 10 09:37:12 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the continents-off-test branch Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment