Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue #1106: Continents are off. #1717

Merged
merged 2 commits into from Dec 10, 2015
Merged

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Dec 2, 2015

The fix for this issue is at 658ac44.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Dec 2, 2015

import sys
import vcs

pth = os.path.join(os.path.dirname(__file__),"..")
Copy link
Contributor

@sankhesh sankhesh Dec 2, 2015

@danlipsa It would be good if new code followed PEP8 convention.

In this case, there should be a space after the comma.

Copy link
Contributor

@doutriaux1 doutriaux1 Dec 2, 2015

the pep8 police 😉 I'm with you @danlipsa "vive la resistance"

Copy link
Contributor

@sankhesh sankhesh Dec 2, 2015

@aashish24 Lets crush the resistance. 💣

@danlipsa danlipsa force-pushed the continents-off-test branch from a94f4fa to ce8956a Dec 2, 2015
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Dec 2, 2015

@sankhesh @doutriaux1 I have addressed all comments.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Dec 3, 2015

thx @danlipsa did you also update the baseline with the not antialiased pix?

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 3, 2015

@doutriaux1 does n't look like it. I am going to upload a new baseline.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Dec 3, 2015

@doutriaux1 @aashish24 I did upload the larger file, which I think is also not antialiased.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Dec 4, 2015

@doutriaux1 @aashish24 is this ready?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Dec 10, 2015

@aashish24 @doutriaux1 Can we merge this?

doutriaux1 added a commit that referenced this issue Dec 10, 2015
Add test for issue #1106: Continents are off.
@doutriaux1 doutriaux1 merged commit 8087cd0 into master Dec 10, 2015
3 of 8 checks passed
@doutriaux1 doutriaux1 deleted the continents-off-test branch Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants