New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1730 mesh with missing vertices #1731

Merged
merged 7 commits into from Dec 12, 2015

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Dec 10, 2015

@aashish24 @sankhesh thanks to @sankhesh help I got the shapes to be drawn correctly, but they still appear to be drawn as missing, I think the "nan" bit throws off VTK ? Help wanted 馃槈

doutriaux1 added some commits Dec 10, 2015

Added a test for issue #1730
will eventually fix #1730
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 10, 2015

great @doutriaux1 how should we handle nan?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 10, 2015

@aashish24 basically nan means ignore this vertice that's how we handle grids which have some cells with a different number of vertices between them (3 vs 4 here) we use the greatest number of vertices and set the unused ones to missing, which @sankhesh suggested we convert to nan for VTK. Unfortunately VTK does pick the correct shape now but seems to mark the cell has bad

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 11, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 11, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented on testing/vcs/test_vcs_meshfill_vertices_issue.py in 4a29d78 Dec 11, 2015

@doutriaux1 can you wrap this long line?

This comment has been minimized.

Member

doutriaux1 replied Dec 11, 2015

@aashish24 feel free to push changes for these things.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 11, 2015

@doutriaux1 if this is a uniform grid, we should probably using masking array. Thoughts?

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Dec 11, 2015

@aashish24 Actually, this is for meshfill, which is inherently a non-uniform grid.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 11, 2015

@aashish24 it is actually using masked arrays anyway. And @chaosphere2112 is right these are non-uniform grids, and in this case really non-uniform (different number of vertices for each cell)

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 11, 2015

@doutriaux1 thanks.. can you fix the style issue?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 11, 2015

nah...

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 11, 2015

@chaosphere2112 sorryI meant to say regular grid / structured grid which curve linear is.

doutriaux1 and others added some commits Dec 11, 2015

@@ -263,7 +263,7 @@ def genGrid(data1, data2, gm, deep=True, grid=None, geo=None):
xM = m[:, 1].max()
ym = m[:, 0].min()
yM = m[:, 0].max()
N = m.shape[0]
numberOfCells = m.shape[0]

This comment has been minimized.

@aashish24

aashish24 Dec 12, 2015

Contributor

nice var name thanks 馃憤

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 12, 2015

@doutriaux1 changes LGTM 馃憤

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 12, 2015

If bots are happy, I am going to merge it.. nice job @doutriaux1 @sankhesh

aashish24 added a commit that referenced this pull request Dec 12, 2015

Merge pull request #1731 from UV-CDAT/issue_1730_mesh_with_missing_ve鈥
鈥tices

Issue 1730 mesh with missing vertices

@aashish24 aashish24 merged commit 5c05aca into master Dec 12, 2015

6 of 8 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'In Queue: 4' (Fri Dec 11 20:17:18 2015)
Details
cont-int/LLNL/Darwin-Mac (FULL) running 'ctest -j4 -D Experimental' (Fri Dec 11 22:06:04 2015)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Fri Dec 11 21:30:14 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Fri Dec 11 20:44:45 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Fri Dec 11 21:12:15 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the issue_1730_mesh_with_missing_vertices branch Dec 12, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 14, 2015

@aashish24 please do not forget to merge baselines as well. Thanks. I just merged it in. Thx @durack1 for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment