Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1732 #1733

Merged
merged 2 commits into from Dec 14, 2015
Merged

fix #1732 #1733

merged 2 commits into from Dec 14, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Dec 10, 2015

No description provided.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Dec 10, 2015

@sankhesh @aashish24 if that doesn't break the test suite it should be a quick review

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Dec 10, 2015

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Dec 10, 2015

OK I uploaded the wrong pix... Back soon

@@ -1199,7 +1199,7 @@ def prepFillarea(renWin, farea, cmap=None):
if opacity is not None:
opacity = farea.opacity[i]
else:
opacity = 100
opacity = None
Copy link
Contributor

@aashish24 aashish24 Dec 12, 2015

what happened here?

Copy link
Contributor Author

@doutriaux1 doutriaux1 Dec 14, 2015

If it was 100 it would not respect the color's own opacity. so if you set to (100,0,0,50) you wolud have a filled red square instead of half transparent square.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 14, 2015

@doutriaux1 changes looks good to me.. thanks for the explanation..

@aashish24 aashish24 merged commit 5e022b7 into master Dec 14, 2015
5 of 8 checks passed
@aashish24 aashish24 deleted the issue_1732_fillarea_no_transparency branch Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants