New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1732 #1733

Merged
merged 2 commits into from Dec 14, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Dec 10, 2015

No description provided.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 10, 2015

@sankhesh @aashish24 if that doesn't break the test suite it should be a quick review

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 10, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 10, 2015

OK I uploaded the wrong pix... Back soon

@@ -1199,7 +1199,7 @@ def prepFillarea(renWin, farea, cmap=None):
if opacity is not None:
opacity = farea.opacity[i]
else:
opacity = 100
opacity = None

This comment has been minimized.

@aashish24

aashish24 Dec 12, 2015

Contributor

what happened here?

This comment has been minimized.

@doutriaux1

doutriaux1 Dec 14, 2015

Member

If it was 100 it would not respect the color's own opacity. so if you set to (100,0,0,50) you wolud have a filled red square instead of half transparent square.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 14, 2015

@doutriaux1 changes looks good to me.. thanks for the explanation..

aashish24 added a commit that referenced this pull request Dec 14, 2015

@aashish24 aashish24 merged commit 5e022b7 into master Dec 14, 2015

5 of 8 checks passed

cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Fri Dec 11 14:37:24 2015)
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j12 -D Experimental' (Sun Dec 13 21:45:40 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac (FULL) running 'ctest -j4 -D Experimental' (Fri Dec 11 16:41:22 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Fri Dec 11 12:36:02 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Fri Dec 11 13:42:00 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the issue_1732_fillarea_no_transparency branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment