Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1734 non contiguous levs #1735

Merged
merged 3 commits into from Dec 15, 2015
Merged

Issue 1734 non contiguous levs #1735

merged 3 commits into from Dec 15, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Dec 11, 2015

@sankhesh @aashish24 @chaosphere2112 please review

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Dec 11, 2015

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 12, 2015

@doutriaux1 this will some time to review.. more than minor change of code..

@danlipsa it would be nice if you can look into this branch as well.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Dec 14, 2015

@aashish24 it is really minor, I just unified the function call, it was the same function called from isofill/boxfill/meshfill so I moved it to the mother class instead.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 14, 2015

ah..thanks @doutriaux1 looking into it..

doutriaux1
Copy link
Contributor

doutriaux1 commented on 984345a Dec 14, 2015

@aashish24 that's the real change actually, not much.

doutriaux1
Copy link
Contributor

doutriaux1 commented on 984345a Dec 14, 2015

and that bit.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 15, 2015

@doutriaux1 looks good to me.. crunchy is having some serious issues.. can you have a look at it?

Thanks

aashish24 added a commit that referenced this issue Dec 15, 2015
@aashish24 aashish24 merged commit cd5cf9f into master Dec 15, 2015
6 of 8 checks passed
@aashish24 aashish24 deleted the issue_1734_non_contiguous_levs branch Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants