New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1734 non contiguous levs #1735

Merged
merged 3 commits into from Dec 15, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Dec 11, 2015

doutriaux1 added some commits Dec 11, 2015

@doutriaux1 doutriaux1 referenced this pull request Dec 11, 2015

Merged

new baselines for #1734 #95

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 11, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 12, 2015

@doutriaux1 this will some time to review.. more than minor change of code..

@danlipsa it would be nice if you can look into this branch as well.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 14, 2015

@aashish24 it is really minor, I just unified the function call, it was the same function called from isofill/boxfill/meshfill so I moved it to the mother class instead.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 14, 2015

ah..thanks @doutriaux1 looking into it..

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented on Packages/vcs/Lib/vcsvtk/isofillpipeline.py in 984345a Dec 14, 2015

@aashish24 that's the real change actually, not much.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented on Packages/vcs/Lib/vcsvtk/isofillpipeline.py in 984345a Dec 14, 2015

and that bit.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 15, 2015

@doutriaux1 looks good to me.. crunchy is having some serious issues.. can you have a look at it?

Thanks

aashish24 added a commit that referenced this pull request Dec 15, 2015

@aashish24 aashish24 merged commit cd5cf9f into master Dec 15, 2015

6 of 8 checks passed

cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j12 -D Experimental' (Sun Dec 13 01:46:17 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac (FULL) running 'ctest -j4 -D Experimental' (Fri Dec 11 12:53:26 2015)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'ctest -j4 -D Experimental' (Fri Dec 11 12:09:11 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Fri Dec 11 11:24:55 2015)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Fri Dec 11 11:54:48 2015)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the issue_1734_non_contiguous_levs branch Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment