New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate longitude wrap #1736

Merged
merged 1 commit into from Dec 23, 2015

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Dec 14, 2015

No description provided.

@@ -609,6 +609,8 @@ def project(pts, projection, wc, geo=None):
pname = projDict.get(projection._type, projection.type)
projName = pname
pd.SetName(projName)
pd.SetOptionalParameter("over", "true")
pd.SetCentralMeridian(float(xm + xM) / 2.0)

This comment has been minimized.

@doutriaux1

doutriaux1 Dec 14, 2015

Member

@danlipsa what about case where user specified the central meridian?

This comment has been minimized.

@danlipsa

danlipsa Dec 14, 2015

Contributor

I just seen your post about this. I'll look at it and use that value instead.

This comment has been minimized.

@aashish24

aashish24 Dec 14, 2015

Contributor

@danlipsa what about case where user specified the central meridian?

@doutriaux1 that what was the question @danlipsa asked in the issue. How does someone specify that in vcs?

This comment has been minimized.

@doutriaux1

doutriaux1 Dec 14, 2015

Member

@aashish24 I replied to @danlipsa he's on it. Thx.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 14, 2015

thanks @doutriaux1

@danlipsa when you make a pull request which has new baselines, could you please reference to the data pull request as well?

CDAT/uvcdat-testdata#96

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 14, 2015

@doutriaux1 once this and the clipped data (and two of yours merged in) we should finalize the release.. what you think?

@doutriaux1 doutriaux1 referenced this pull request Dec 14, 2015

Merged

Clipped data #1723

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 14, 2015

@sankhesh was VERY close from getting XCode 7 in, I would like to have this in as well!

@danlipsa danlipsa force-pushed the duplicate-longitude-wrap branch 4 times, most recently from f68d2f9 to 1412d21 Dec 14, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 17, 2015

@danlipsa some tests arw failing. Are you lookinf intonit?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 17, 2015

@aashish24 @sankhesh @doutriaux1 This is strange. For some machines all test pass, for some there are 85 tests failing. I don't see what is different about the machines that fail. Any ideas?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 17, 2015

weird I was going to say "MESA" but no. Very odd. But most machines fail though.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Dec 17, 2015

I'm compiling on my Mac to see if I can reproduce those issues. Hopefully I can.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 17, 2015

@doutriaux1 @aashish24 At least on https://open.cdash.org/viewTest.php?onlyfailed&buildid=4151636
seems to be a problem with the baselines
https://open.cdash.org/testDetails.php?test=402903788&build=4151636
has the wrong baseline.
Unfortunatelly it has the wrong test image as well.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 17, 2015

@aashish24 @doutriaux1 Thanks @sankhesh for building uvdat on your mac laptop and duplicating the problem. It seems that proj4 behaves differently on that build. Removing +over option fixes the problem for the -3 projection. I am building uvcdat on my mac laptop to debug the proj4 behavior.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 18, 2015

@aashish24 @sankhesh @doutriaux1 I have a hard time building uvcdat on my mac. One problem is that cdtime and cdms2 tried to link against libpng15 which did not exist on my system. I fixed this by changing the link command to link to libpng. Now I get:

ImportError: dlopen(/Users/danlipsa/uvcdat/build/install/Externals/lib/python2.7/site-packages/vtk/vtkCommonCorePython.so, 2): Library not loaded: libvtkCommonCorePython27D-6.3.1.dylib
Referenced from: /Users/danlipsa/uvcdat/build/install/Externals/lib/python2.7/site-packages/vtk/vtkCommonCorePython.so
Reason: image not found

However that library is in:
ls -l install/Externals/lib/libvtkCommonCorePython27D-6.3.dylib
lrwxr-xr-x 1 danlipsa staff 37 Dec 17 19:09 install/Externals/lib/libvtkCommonCorePython27D-6.3.dylib -> libvtkCommonCorePython27D-6.3.1.dylib
Any suggestions?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 19, 2015

OK, I can reproduce the proj4 problem on my laptop. The build problem I was seeing (libvtkCommonCorePython27D) is still there but that appears only when you run the test through runtest. If you run it directly through python it works fine.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 21, 2015

@aashish24 @sankhesh @doutriaux1 I have a hard time building uvcdat on my mac. One problem is that cdtime and cdms2 tried to link against libpng15 which did not exist on my system. I fixed this by changing the link command to link to libpng. Now I get:

@danlipsa you have to install xquartz (https://github.com/UV-CDAT/uvcdat/wiki/Install-on-Mac-OS-X) and then make sure you build from scratch (and remove any workardounds that you may have).

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 21, 2015

Thanks @aashish24 I used xwindows installed with mac port. I will try with xquarts.

BUG #1728: Proj4 wraps longitudes to -180,180.
We pass two additional options to proj4
+over to not wrap longitude values
+lon_0 to set the central meridian

This fixes the wrapping issues we were seeing.

@danlipsa danlipsa force-pushed the duplicate-longitude-wrap branch from 1412d21 to 0552f7a Dec 21, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Dec 21, 2015

@danlipsa the mangling will be a problem since I won't have time tomorrow to look into it. the code to transition to newer proj4 is there. We would also need to build proj4 as well.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Dec 23, 2015

@doutriaux1 Are the buildbots ok? They been running for more than 24 hours.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Dec 23, 2015

I think sometihng got stuck, I'm updating the bots system to timeout.

doutriaux1 added a commit that referenced this pull request Dec 23, 2015

@doutriaux1 doutriaux1 merged commit 07a5590 into master Dec 23, 2015

3 of 7 checks passed

cont-int/LLNL/Darwin-Mac (FULL) running 'In Queue: 8' (Mon Dec 21 11:36:50 2015)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'In Queue: 8' (Mon Dec 21 11:36:49 2015)
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'In Queue: 16' (Mon Dec 21 11:36:50 2015)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'In Queue: 2' (Mon Dec 21 11:36:48 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the duplicate-longitude-wrap branch Dec 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment