Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed conversion to base64 string #1757

Merged
merged 2 commits into from Jan 6, 2016
Merged

Fixed conversion to base64 string #1757

merged 2 commits into from Jan 6, 2016

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jan 6, 2016

No description provided.

@aashish24 aashish24 force-pushed the fix_plot_image_to_base64 branch from e80194b to c00ba11 Jan 6, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Jan 6, 2016

@doutriaux1 please review. You may want to checkout branch locally since the diff is really confusing because of the indentation changes I made.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jan 6, 2016

@aashish24 it's ok I looked at the diff on your first commit. I remember we looked at this together. Changes look good to me. Looks like my bots are dead again... Will test locally but I don't expect any issue. I'm tempted though to ask you to edit your last commit message because you have a typo in it 😜 You know just so that the history look good 😉

@aashish24 aashish24 force-pushed the fix_plot_image_to_base64 branch from 437750d to 77e56d2 Jan 6, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Jan 6, 2016

I'm tempted though to ask you to edit your last commit message because you have a typo in it You know just so that the history look good

you should ask. Not sure why my spell check didn't get it.

@aashish24 aashish24 force-pushed the fix_plot_image_to_base64 branch from 77e56d2 to 0c43b9e Jan 6, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Jan 6, 2016

thanks @doutriaux1 if looks good can I merge it?

@aashish24 aashish24 force-pushed the fix_plot_image_to_base64 branch from 0c43b9e to 92a3ecc Jan 6, 2016
doutriaux1 added a commit that referenced this issue Jan 6, 2016
@doutriaux1 doutriaux1 merged commit c4efa19 into master Jan 6, 2016
5 of 8 checks passed
@doutriaux1 doutriaux1 deleted the fix_plot_image_to_base64 branch Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants