Issue 1763 lambert #1768

doutriaux1 · 2016-01-06T23:49:15Z

No description provided.

… a func

doutriaux1 · 2016-01-07T02:44:36Z

@aashish24 please review. Failing test are due to the proj4 bug.

doutriaux1 · 2016-01-07T02:45:11Z

@sankhesh @danlipsa @chaosphere2112 please review as well. proj4 bug is causing failures.

aashish24 · 2016-01-07T04:11:39Z

Packages/vcs/Lib/vcs2vtk.py

+    projName = pname
+    pd.SetName(projName)
+    if projection.type == 'aeqd':
+        # this is a temporary branch to keep the same


this comment seems absurd

I agree but since it was here before I left it in. I might mean something to someone...

I would say remove it. Its not useful anymore.

sankhesh · 2016-01-07T15:09:00Z

Packages/vcs/Lib/vcs2vtk.py

-                if ((not hasattr(projection, 'centralmeridian') or
-                     numpy.allclose(projection.centralmeridian, 1e+20))):
-                    pd.SetCentralMeridian(float(xm + xM) / 2.0)
+        apply_proj_parameters(pd, projection, xm, xM, ym, yM)


👍 Good to remove code duplication

doutriaux1 · 2016-01-07T17:02:46Z

@aashish24 ok will remove comments and repush

doutriaux1 · 2016-01-07T17:05:45Z

@aashish24 pushed. Please review again and merge at your convenience

aashish24 · 2016-01-07T17:07:10Z

thanks @doutriaux1 looks great! Also thanks for removing duplicated code BIG 👍 from me.

LGTM 👍

since proj4 has issue with it on some systems

doutriaux1 · 2016-01-07T18:01:52Z

@aashish24 I'm adding the bit to turn off over parameter please wait before merging

made test pass on my weird 3 screen system

doutriaux1 · 2016-01-07T19:26:13Z

@aashish24 tests seem to now pass on my mac.

optional param over needs to ACTIVELY be set to false in order to get rid of the bug

aashish24 · 2016-01-07T23:41:00Z

@doutriaux1 I am wondering why other bots are stuck?

doutriaux1 · 2016-01-07T23:56:55Z

me too... I keep restarting them... something to do with the Queueing system when a new PR goes to the Queue it seems to seriously mess up the macs especially... Had to kill everything a few times...

doutriaux1 · 2016-01-08T00:14:17Z

wow... On my mac I HAD TO set "over" to false in order to consistently get correct result for lambert plots otherwise i got a completely different plot every time. Now that this is in it seems to have broken Ubuntu/MESA... I'm at a loss here!! @danlipsa @aashish24 please take over that branch and let me know..

aashish24 · 2016-01-08T05:33:59Z

@doutriaux1 @danlipsa I have added support newer proj4 (#1773), as of writing this I am still waiting on dashbords to finish.

aashish24 · 2016-01-08T05:36:09Z

Here is the corresponding VTK pull request: https://github.com/UV-CDAT/VTK/pull/14/files

doutriaux1 · 2016-01-08T07:07:29Z

That is great when newer proj4 is in let me update this PR so that over iscalways on.

cannot do a global lambert it makes no sense lambert breaks on apple

doutriaux1 · 2016-01-10T06:54:43Z

@aashish24 @danlipsa @chaosphere2112 I'm done with the code, I merged the noticklabel elliptical branch in this so we only need to update the baseline once. It's mostly there but animation baselines need update and a few others. I probably won't have time to look into this tomorrw, so feel free to at least review the code now and if you could update the baselines it would be awesome to! Thanks.

aashish24 · 2016-01-11T02:11:59Z

@doutriaux1 the polar tests are failing: Look here:

https://open.cdash.org/testSummary.php?project=44&name=vcs_test_animate_projected_isofill_polar&date=2016-01-10

I am not even sure what the test is testing as the baseline itself is looking pretty bad and the new image is worse.

doutriaux1 · 2016-01-11T06:41:59Z

I didn't look at animation test. I'll look in the morning.

danlipsa · 2016-01-11T16:35:40Z

Packages/vcs/Lib/projection.py

@@ -21,6 +21,9 @@
 round_projections = ['polar (non gctp)', 'stereographic',
                     'orthographic', "ortho", ]

+no_over_proj4_parameter_projections = round_projections+["aeqd", "lambert conformal c"]


In my original pull request I also did not pass +over for 'polar stereographic'. Maybe this is the reason why this you are failing some polar tests. Besides that looks good to me.

shouldn't be, because polar do not go to the part of the code that uses no_over_proj4_parameter_projections I will take a look at the animation test now.

ok i see the issue, the parameter passed to the projection should not be polar, it should be polar (non gctp) or -3

The animation test are sol long I'm removing the polar projection from anim test. I don't think animating many projections is useful anyway, one test on an animated projection is enough.

The animation test are sol long I'm removing the polar projection from anim test. I don't think animating many projections is useful anyway, one test on an animated projection is enough.

Sounds good but make sure that other polar projections are still working.

I did, they work, or at least they work so that they do not exhibit the bug...

projection have their own tests, one test of a animated plot with projection should be enough

doutriaux1 · 2016-01-12T00:13:58Z

@aashish24 @chaosphere2112 @danlipsa I think we should be good know, let's see what the bots think.

doutriaux1 · 2016-01-12T01:23:29Z

OK rh full issues are most likely vnc server issues, the failed tests are the ones that open a window to the screeb

aashish24 · 2016-01-12T01:55:31Z

@doutriaux1 looks like this test is a genuine failure: https://open.cdash.org/testDetails.php?test=409325568&build=4186478

aashish24 · 2016-01-12T01:58:04Z

Also, @doutriaux1 if you can please squash your commits or update the comments: For example: even height could use more words.

Other than that, its looks okay to me. I am going to test the projection stuff some more post 2.4.

doutriaux1 · 2016-01-12T04:24:25Z

@aashish24 updating files for Mac failures. Test failure look very similar to vtkweb issue. Not a show stopper, but I will double check it tomorrow. Will try to squash but probably won't get to it until tomorrow.

doutriaux1 · 2016-01-12T04:41:32Z

@aashish crunchy is acting up and has been started over vpn and xfvb I'm not too concerned about the test failure. Updated Mac baselines. Restarting bots to make sure it's all green.

doutriaux1 · 2016-01-12T04:42:44Z

@aashish24 why aren't your machine ctest results visible?

jbeezley · 2016-01-12T05:10:23Z

@doutriaux1 There was a timeout cloning a repo during the build. I just retriggered it.

doutriaux1 · 2016-01-12T14:29:46Z

@jbeezley thx! My mac bot also got hanged, restarting them now...

doutriaux1 · 2016-01-12T15:01:45Z

@aashish24 squashed commit and retriggered build for macs. Let's merge as soon as possible, double checking the crunchy issue

doutriaux1 · 2016-01-12T17:06:32Z

@aashish24 macs are happy now, Ubunutu and RH6 as well. We should merge so we can tag 2.4.0

aashish24 · 2016-01-12T17:07:10Z

@doutriaux1 looking into it right now.

doutriaux1 · 2016-01-12T17:09:57Z

@aashish24 thx!

aashish24 · 2016-01-12T17:15:22Z

@doutriaux1 Looks good thanks for updating the commits.

Issue 1763 lambert

aashish24 · 2016-01-12T17:32:12Z

@doutriaux1 you are welcome. Okay if I go ahead and create and tag the release branch? like we discussed last time.

doutriaux1 · 2016-01-12T17:42:24Z

@aashish24 let's wait a couple of days for the tag I would like @williams13 and @potter2 to take a look first.

aashish24 · 2016-01-12T17:45:42Z

@aashish24 let's wait a couple of days for the tag I would like @williams13 and @potter2 to take a look first.

Okay, will wait. But if that process takes longer than 1-2 days we would have to start merging other pending work (or new work) in master. We can always pick a older sha for release so that's not a problem.

doutriaux1 added 6 commits January 6, 2016 10:56

got lambert to be pretty automagically

4de570e

flake8ed

f63399d

param were applied in two different palce the same way, moved code to…

2f98e54

… a func

flake8ed and corrected func name

7eb47e1

Added test to cmakelist and made it bg mode

f1f671d

fix merge conflicts with master

766a97d

aashish24 reviewed Jan 7, 2016
View reviewed changes

doutriaux1 added 2 commits January 7, 2016 00:52

turn off label on mollweide/robinson x axes

eb433bc

flake8ed

8a523f2

sankhesh reviewed Jan 7, 2016
View reviewed changes

removed useless comments

bd5ecea

added option to NOT set the over parameter

bb6d2c6

since proj4 has issue with it on some systems

flake8ed

c632297

made test pass on my weird 3 screen system

looks like some C++ uninitialize param in proj4

b4339ce

optional param over needs to ACTIVELY be set to false in order to get rid of the bug

doutriaux1 added 2 commits January 9, 2016 09:59

took out bad lambert test

28452b1

cannot do a global lambert it makes no sense lambert breaks on apple

merged no ellipt label in

526a941

danlipsa reviewed Jan 11, 2016
View reviewed changes

no need to test animations with so many projections

8a7eea5

projection have their own tests, one test of a animated plot with projection should be enough

doutriaux1 added 2 commits January 12, 2016 06:48

hoping that an even number of lines and bigger pix will help test pass

0250e70

upped a bit def threshold

3d751cc

doutriaux1 force-pushed the issue_1763_lambert branch from 6a17ae3 to 3d751cc Compare January 12, 2016 14:49

aashish24 added a commit that referenced this pull request Jan 12, 2016

Merge pull request #1768 from UV-CDAT/issue_1763_lambert

6e7db69

Issue 1763 lambert

aashish24 merged commit 6e7db69 into master Jan 12, 2016

doutriaux1 deleted the issue_1763_lambert branch January 12, 2016 17:40

Issue 1763 lambert #1768

Issue 1763 lambert #1768

Conversation

doutriaux1 commented Jan 6, 2016

doutriaux1 commented Jan 7, 2016

doutriaux1 commented Jan 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doutriaux1 commented Jan 7, 2016

doutriaux1 commented Jan 7, 2016

aashish24 commented Jan 7, 2016

doutriaux1 commented Jan 7, 2016

doutriaux1 commented Jan 7, 2016

aashish24 commented Jan 7, 2016

doutriaux1 commented Jan 7, 2016

doutriaux1 commented Jan 8, 2016

aashish24 commented Jan 8, 2016

aashish24 commented Jan 8, 2016

doutriaux1 commented Jan 8, 2016

doutriaux1 commented Jan 10, 2016

aashish24 commented Jan 11, 2016

doutriaux1 commented Jan 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doutriaux1 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

aashish24 commented Jan 12, 2016

aashish24 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

jbeezley commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

aashish24 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

aashish24 commented Jan 12, 2016

aashish24 commented Jan 12, 2016

doutriaux1 commented Jan 12, 2016

aashish24 commented Jan 12, 2016