New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where hovering over meshfill raised exceptions #1769

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Jan 7, 2016

Fixes #1764 by adding a missing try/except

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 7, 2016

@chaosphere2112 why back would not be a vtkProp?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 7, 2016

Other than that LGTM 👍

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Jan 7, 2016

Meshfill apparently stores a string in the display plot's backend; a pretty diverse list of objects get shoved in there, not exclusively vtkProps. I had added try/except checks for that call in two other places, just missed it for this one.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 7, 2016

aashish24 added a commit that referenced this pull request Jan 7, 2016

Merge pull request #1769 from UV-CDAT/fix_1764
Fixes bug where hovering over meshfill raised exceptions

@aashish24 aashish24 merged commit 11ceb27 into master Jan 7, 2016

4 of 9 checks passed

cont-int/LLNL/Darwin-Mac (FULL) running 'make -j4' (Wed Jan 6 18:52:49 2016)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'make -j4' (Wed Jan 6 18:52:03 2016)
Details
cont-int/LLNL/Darwin-Mac LEAN running 'make -j4' (Wed Jan 6 18:51:23 2016)
Details
cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j15 -D Experimental' (Wed Jan 6 19:07:50 2016)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'make -j15' (Wed Jan 6 19:42:37 2016)
Details
cont-int/LLNL/Linux-RH6 (MESA) running 'ctest -j12 -D Experimental' (Wed Jan 6 19:40:39 2016)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the fix_1764 branch Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment