New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got rid of screen size logic from test #1793

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
4 participants
@chaosphere2112
Contributor

chaosphere2112 commented Jan 14, 2016

Not entirely certain why I put it there in the first place; test should run perfectly fine with a window that's bigger than the monitor.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Jan 14, 2016

Fixes #1792

@durack1

This comment has been minimized.

Member

durack1 commented Jan 14, 2016

@chaosphere2112 probably had something to do with OS X 10.8.old or was it Windows 3.1😉

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Jan 14, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 14, 2016

@chaosphere2112 the bots use to pass before anyway. Does it pass again on your ubuntu?

@@ -46,12 +46,6 @@ def test_canvas_size(c, size, via):
info = c.canvasinfo()
w, h = size
# Make sure size fits on screen bounds
screen_w, screen_h = c.backend.renWin.GetScreenSize()

This comment has been minimized.

@doutriaux1

doutriaux1 Jan 14, 2016

Member

I think GetScreenSize either works or not in VTK... Never could figure out when it does or not, so it probably a combination of this + small screen

This comment has been minimized.

@aashish24

aashish24 Jan 20, 2016

Contributor

@doutriaux1 if you remember @dlonie pushed a fix for this and now it should work on all systems.

@durack1

This comment has been minimized.

Member

durack1 commented Jan 14, 2016

@chaosphere2112 @doutriaux1 just as a comment, if you are depending on a vnc configuration to test things, then I'd be pretty skeptical that it's representative of a physical machine configuration.. vnc provides super quirky results with graphics, trying to plot things etc etc.. Particularly if it's in a background mode..

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 20, 2016

@chaosphere2112 changes looks good to me. Yes, I agree that the test was not that useful since the initial screen size could be some number depending on the X or the underlying window system.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 20, 2016

@doutriaux1 I am merging this.

aashish24 added a commit that referenced this pull request Jan 20, 2016

Merge pull request #1793 from UV-CDAT/fix_init_size_open
Got rid of screen size logic from test

@aashish24 aashish24 merged commit 6061e0f into master Jan 20, 2016

5 of 7 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
cont-int/LLNL/Darwin-Mac (FULL) 'In Queue: 0' (Thu Jan 14 13:48:53 2016)
Details
cont-int/LLNL/Darwin-Mac LEAN 'ctest -j4 -D Experi' (Thu Jan 14 14:00:44 2016)
Details
cont-int/LLNL/Linux-RH6 (MESA) 'ctest -j12 -D Exper' (Thu Jan 14 14:13:52 2016)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) 'ctest -j15 -D Exper' (Thu Jan 14 14:39:23 2016)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the fix_init_size_open branch Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment