Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that was breaking continents when set at canvas level #1794

Merged
merged 3 commits into from Jan 20, 2016

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Jan 15, 2016

Found a bug that wasn't properly covered by my test_continents script; if you set the continents at the canvas level, rather than by using the continents argument of the plot function, the continents would be ignored.

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Jan 19, 2016

@doutriaux1 Flake8'd

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jan 20, 2016

@chaosphere2112 changes looks good to me. LGTM 👍

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jan 20, 2016

LGTM 👍

sankhesh added a commit that referenced this issue Jan 20, 2016
Fixed bug that was breaking continents when set at canvas level
@sankhesh sankhesh merged commit 95d348a into master Jan 20, 2016
4 of 8 checks passed
@chaosphere2112 chaosphere2112 deleted the fix_setcontinentstype branch Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants