New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that was breaking continents when set at canvas level #1794

Merged
merged 3 commits into from Jan 20, 2016

Conversation

Projects
None yet
3 participants
@chaosphere2112
Contributor

chaosphere2112 commented Jan 15, 2016

Found a bug that wasn't properly covered by my test_continents script; if you set the continents at the canvas level, rather than by using the continents argument of the plot function, the continents would be ignored.

@chaosphere2112 chaosphere2112 self-assigned this Jan 15, 2016

@chaosphere2112 chaosphere2112 added this to the 2.4 milestone Jan 15, 2016

Sam Fries added some commits Jan 15, 2016

Sam Fries
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Jan 19, 2016

@doutriaux1 Flake8'd

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 20, 2016

@chaosphere2112 changes looks good to me. LGTM 👍

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Jan 20, 2016

LGTM 👍

sankhesh added a commit that referenced this pull request Jan 20, 2016

Merge pull request #1794 from UV-CDAT/fix_setcontinentstype
Fixed bug that was breaking continents when set at canvas level

@sankhesh sankhesh merged commit 95d348a into master Jan 20, 2016

4 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
cont-int/LLNL/Darwin-Mac (FULL) 'In Queue: 0' (Tue Jan 19 13:56:11 2016)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) 'In Queue: 0' (Tue Jan 19 13:56:09 2016)
Details
cont-int/LLNL/Darwin-Mac LEAN 'In Queue: 0' (Tue Jan 19 13:56:08 2016)
Details
cont-int/LLNL/Linux-RH6 (MESA) 'ctest -j12 -D Exper' (Tue Jan 19 14:22:58 2016)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) 'ctest -j15 -D Exper' (Tue Jan 19 14:44:32 2016)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@chaosphere2112 chaosphere2112 deleted the fix_setcontinentstype branch Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment