Fixed bug that was breaking continents when set at canvas level #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doutriaux1 Flake8'd |
|
@chaosphere2112 changes looks good to me. LGTM 👍 |
|
LGTM 👍 |
sankhesh
added a commit
that referenced
this pull request
Jan 20, 2016
Fixed bug that was breaking continents when set at canvas level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug that wasn't properly covered by my test_continents script; if you set the continents at the canvas level, rather than by using the continents argument of the plot function, the continents would be ignored.