-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable projected click, fix time values #1800
Conversation
@chaosphere2112 we should really |
@chaosphere2112 okay if @danlipsa and @aashish take over this branch? |
@aashish24 @doutriaux1 Sure thing, I was just getting this pushed out. I do need to make one tweak to the time axis logic still, but other than that anyone can take it over. |
@chaosphere2112 roger that. |
@danlipsa can you look in this for the projected plots? |
@doutriaux1 @chaosphere2112 @aashish24 I think a proper fix for this may need plotting_dataset_bounds which I return from plot in my branch: |
@danlipsa this is not holding the release (at least not yet :)) |
That's good. :-) |
Disable projected click, fix time values
When clicking on data that was projected, the wrong value was displayed. The issue is that we are not "de-projecting" the coordinates of the mouse. I wasn't able to come up with a quick fix for that (as my ability to reason through projection stuff is pretty limited), so I disabled the value checker for all nonlinear projections. I also removed some redundant logic for extracting the world coordinate (we had a call in
vcs.utils
for this). As an added bonus, we now get correct values when clicking on the plot after having animated it or advanced the current frame beyond the initial frame now. I'm pretty sure the time logic I used is solid, and it should fall back nicely to the "N/A" if it's not able to determine which axis is time.@sankhesh @doutriaux1 @aashish24 @danlipsa Please review and merge so we can release.