Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1801 old scr files #1820

Merged
merged 19 commits into from Mar 22, 2016
Merged

Issue 1801 old scr files #1820

merged 19 commits into from Mar 22, 2016

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 10, 2016

@aashish24 @danlipsa @sankhesh 99% fixes for reading VERY old vcs script files, but there are a few tweaks in there for setting line attributes using an actual line object or its name, please review.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 10, 2016

@@ -877,6 +883,10 @@ def checkLineType(self, name, value):
hvalue = 'long-dash'
elif (queries.isline(value) == 1):
hvalue = value.name
elif value in vcs.elements["line"]:
self.linecolor = vcs.elements["line"][value].color[0]
Copy link
Contributor

@sankhesh sankhesh Feb 10, 2016

If vcs.elements["line"][value] returns None, these lines would cause a crash.

If you think that will never happen, please ignore.

Copy link
Contributor Author

@doutriaux1 doutriaux1 Feb 10, 2016

yes it should never happen vcs.elements are auto-populated when creating vcs objects

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Feb 10, 2016

Apart from the one comment, LGTM.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 16, 2016

@chaosphere2112 @aashish24 can you please merge. Thanks

vals.append(float(V))
atts[a] = vals
f.style = atts.get("fais", f.style)
if code.find("(") > -1: # ok with have the keywords speeled out
Copy link
Contributor

@chaosphere2112 chaosphere2112 Feb 17, 2016

spelled*

Copy link
Contributor Author

@doutriaux1 doutriaux1 Feb 17, 2016

you don't know about speeling keywords? You should looking into it it's most useful 😉

doutriaux1 added 4 commits Feb 17, 2016
remove debug comment
typo and magic keyword meaning explained when possible
keywords doc
@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 24, 2016

LGTM; does it pass all tests?

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 24, 2016

@chaosphere2112 running it now

doutriaux1 added a commit that referenced this issue Mar 22, 2016
@doutriaux1 doutriaux1 merged commit d919754 into master Mar 22, 2016
0 of 3 checks passed
@doutriaux1 doutriaux1 deleted the issue_1801_old_scr_files branch Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants