New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #1809: Error wrapping a curved grid with masking. #1829

Merged
merged 1 commit into from Feb 16, 2016

Conversation

Projects
None yet
3 participants
@danlipsa
Contributor

danlipsa commented Feb 15, 2016

Failed to consider the case: masking + an unstructured grid that was not
wrapped, so it did not have pedigree ids. This can happen if longitude
range is less than 360. Added a test for this case.

BUG #1809: Error wrapping a curved grid with masking.
Failed to consider the case: masking + an unstructured grid that was not
wrapped, so it did not have pedigree ids. This can happen if longitude
range is less than 360. Added a test for this case.
@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Feb 15, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Feb 15, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 16, 2016

awesome! Thanks @danlipsa I think this will fix PCMDI/pcmdi_metrics#296 @gleckler1 and @durack1 will be delighte. Testing if it fixes the bug and merging

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 16, 2016

@danlipsa I guess your branch that fixes wraping will fix that test as well correct?

doutriaux1 added a commit that referenced this pull request Feb 16, 2016

Merge pull request #1829 from UV-CDAT/wrap-curved-grid
BUG #1809: Error wrapping a curved grid with masking.

@doutriaux1 doutriaux1 merged commit ce70b1b into master Feb 16, 2016

2 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the wrap-curved-grid branch Feb 16, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Feb 16, 2016

@doutriaux1 It does look like it will.

@durack1

This comment has been minimized.

Member

durack1 commented Feb 16, 2016

@gleckler1 time to rebuild and test out that portrait script.. The current metrics master is building UV-CDAT master in which the merge above is now in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment