Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for BUG # 1728: wrapping data creates long cells #1830

Merged
merged 1 commit into from
Feb 18, 2016

Conversation

danlipsa
Copy link
Contributor

No description provided.

@danlipsa
Copy link
Contributor Author

CDAT/uvcdat-testdata#111

@danlipsa
Copy link
Contributor Author

@aashish24 @doutriaux1 @sankhesh Please review.

@doutriaux1
Copy link
Contributor

@danlipsa I only see an added test.

@danlipsa
Copy link
Contributor Author

@doutriaux1 Indeed this is a test we wanted to add since we fixed this bug (adding +over to proj4).

@aashish24
Copy link
Contributor

@danlipsa this is cool! so it works now? (I know I am asking obvious here :))

@doutriaux1
Copy link
Contributor

I see! Ok then can you please clean up the test. I will annotate what's wrong with it.

cdmsfile = cdms2.open(os.path.join(vcs.sample_data, "clt.nc"))
clt2 = cdmsfile('clt')
clt3 = clt2(latitude=(-90.0, 90.0),squeeze=1,longitude=(-180, 200.0),time=('1979-01', '1988-12'),)
axesOperations = eval("{'latitude': 'def', 'longitude': 'def', 'time': 'def'}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless

@danlipsa
Copy link
Contributor Author

@aashish24 Yes, it did work since we added the +over option to proj4.

@danlipsa
Copy link
Contributor Author

@doutriaux1 I cleaned up the test as you suggested.

@doutriaux1
Copy link
Contributor

@danlipsa L#17-#47 can still be removed, all of the gmBoxfill attribute setting lines

@danlipsa
Copy link
Contributor Author

@doutriaux1 Any more comments? I think this is ready to be merged.

doutriaux1 added a commit that referenced this pull request Feb 18, 2016
Add test for BUG # 1728: wrapping data creates long cells
@doutriaux1 doutriaux1 merged commit 6522555 into master Feb 18, 2016
@doutriaux1 doutriaux1 deleted the wrapping-long-cells branch February 18, 2016 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants