Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for BUG # 1728: wrapping data creates long cells #1830

Merged
merged 1 commit into from Feb 18, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Feb 15, 2016

No description provided.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 15, 2016

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 15, 2016

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 16, 2016

@danlipsa I only see an added test.

@danlipsa danlipsa force-pushed the wrapping-long-cells branch from 1ea219a to 1676bfc Feb 16, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 16, 2016

@doutriaux1 Indeed this is a test we wanted to add since we fixed this bug (adding +over to proj4).

@danlipsa danlipsa force-pushed the wrapping-long-cells branch from 1676bfc to fb0e4e4 Feb 16, 2016
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 16, 2016

@danlipsa this is cool! so it works now? (I know I am asking obvious here :))

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 16, 2016

I see! Ok then can you please clean up the test. I will annotate what's wrong with it.

cdmsfile = cdms2.open(os.path.join(vcs.sample_data, "clt.nc"))
clt2 = cdmsfile('clt')
clt3 = clt2(latitude=(-90.0, 90.0),squeeze=1,longitude=(-180, 200.0),time=('1979-01', '1988-12'),)
axesOperations = eval("{'latitude': 'def', 'longitude': 'def', 'time': 'def'}")
Copy link
Contributor

@doutriaux1 doutriaux1 Feb 16, 2016

useless

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 16, 2016

@aashish24 Yes, it did work since we added the +over option to proj4.

@danlipsa danlipsa force-pushed the wrapping-long-cells branch from fb0e4e4 to a4e51e4 Feb 16, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 16, 2016

@doutriaux1 I cleaned up the test as you suggested.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 16, 2016

@danlipsa L#17-#47 can still be removed, all of the gmBoxfill attribute setting lines

@danlipsa danlipsa force-pushed the wrapping-long-cells branch from a4e51e4 to 4873300 Feb 17, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Feb 18, 2016

@doutriaux1 Any more comments? I think this is ready to be merged.

doutriaux1 added a commit that referenced this issue Feb 18, 2016
Add test for BUG # 1728: wrapping data creates long cells
@doutriaux1 doutriaux1 merged commit 6522555 into master Feb 18, 2016
4 of 6 checks passed
@doutriaux1 doutriaux1 deleted the wrapping-long-cells branch Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants