New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mintics now properly support lists #1870

Merged
merged 1 commit into from Mar 7, 2016

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Mar 3, 2016

I tried to do this in #1869, but @doutriaux1 beat me to the punch and merged it before I ran into this 馃槃

Miniticks were not fetching lists from vcs.elements, this has been remedied. Updated the test... my push to the baseline change was merged already.

Sam Fries
mintics = getattr(gm, axis + 'mtics' + number)
if mintics != '':
if isinstance(mintics, str):
mintics = vcs.elements["list"][mintics]

This comment has been minimized.

@doutriaux1

doutriaux1 Mar 4, 2016

Member

@chaosphere2112 can it ever be '*' ?

doutriaux1 added a commit that referenced this pull request Mar 7, 2016

Merge pull request #1870 from UV-CDAT/fix_min_tics
Mintics now properly support lists

@doutriaux1 doutriaux1 merged commit c4b5f4b into master Mar 7, 2016

2 of 3 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the fix_min_tics branch Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment