New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: ratio=autot works for geographic projected datasets #1896

Merged
merged 1 commit into from Apr 8, 2016

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Mar 28, 2016

Baselines in: CDAT/uvcdat-testdata#118

@danlipsa danlipsa force-pushed the not-stretched-default branch 3 times, most recently from a884f04 to b217859 Mar 29, 2016

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Mar 29, 2016

Work left to do: (from @danlipsa notes)

  • axes names do not follow the data but stay next to the side of the window
  • axes names overlap the data labels in certain cases
  • ratio=autot does not work for meshfill linear projection
  • in the interface you cannot switch ratio=autot on and off. It stays always on.
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 29, 2016

@danlipsa that's neat, did you check that we can still long click a point and it returns the correct info?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 29, 2016

@doutriaux1 I did not. I rely on the tests I added which pass.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 29, 2016

then we should be good.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 30, 2016

@doutriaux1 @aashish24 Do you guys know anything about the diags_test_... tests? I think I picked those issues up from master. I did not have them with my changes on top of a5d3dd6.

Also, vcs_test_continents has a problem.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 30, 2016

these are changing and it seems they keep getting overwritten. I'm going crazy over this, can we please not create any baselines uuntil after the release which should stabilize the metrics baselines. After the release I plan on taking metrics tests out completely and move them to their own space.

@danlipsa danlipsa force-pushed the not-stretched-default branch from b217859 to 12a0eda Mar 30, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 30, 2016

@doutriaux1 Can we push stuff the existing baselines and trigger new builds? If that gets in your way I can wait until this is fixed. Let me know.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 30, 2016

@danlipsa I'm afraid you'll have to re-update the baselines after, not sure.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 30, 2016

@doutriaux1 Thats fine. Let me know when master is fixed and I can rebase.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 31, 2016

@jbeezley Is garant working? It's been working at the tests for a while.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Mar 31, 2016

I turned it off because it has been consistently failing for several weeks now due to network timeouts, and I don't have the time to fix it. I just removed it as an expected status, so it should no longer show up.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 31, 2016

@doutriaux1 @aashish24 Any update on the failing tests on master? diags_test_... and vcs_test_continents and vcs_read_old_scr_2 still fail there. Maybe we should remove the offending commit.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 7, 2016

@doutriaux1 @aashish24 Do I merge this in or any of you want to merge it?

@danlipsa danlipsa force-pushed the not-stretched-default branch from d312515 to 4f7e61f Apr 8, 2016

ENH: ratio=autot works for geographic projected datasets.
ratio=autot does not work for linear projection meshfill.
We leave this for a future commit as it requires further restructuring
of the code.

@danlipsa danlipsa force-pushed the not-stretched-default branch from 4f7e61f to c264c2d Apr 8, 2016

@danlipsa danlipsa merged commit ce6f078 into master Apr 8, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment