Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: ratio=autot works for geographic projected datasets #1896

Merged
merged 1 commit into from
Apr 8, 2016
Merged

ENH: ratio=autot works for geographic projected datasets #1896

merged 1 commit into from
Apr 8, 2016

Conversation

danlipsa
Copy link
Contributor

Baselines in: CDAT/uvcdat-testdata#118

@danlipsa danlipsa force-pushed the not-stretched-default branch 3 times, most recently from a884f04 to b217859 Compare March 29, 2016 02:08
@aashish24
Copy link
Contributor

Work left to do: (from @danlipsa notes)

  • axes names do not follow the data but stay next to the side of the window
  • axes names overlap the data labels in certain cases
  • ratio=autot does not work for meshfill linear projection
  • in the interface you cannot switch ratio=autot on and off. It stays always on.

@doutriaux1
Copy link
Contributor

@danlipsa that's neat, did you check that we can still long click a point and it returns the correct info?

@danlipsa
Copy link
Contributor Author

@doutriaux1 I did not. I rely on the tests I added which pass.

@doutriaux1
Copy link
Contributor

then we should be good.

@danlipsa
Copy link
Contributor Author

@doutriaux1 @aashish24 Do you guys know anything about the diags_test_... tests? I think I picked those issues up from master. I did not have them with my changes on top of a5d3dd6.

Also, vcs_test_continents has a problem.

@doutriaux1
Copy link
Contributor

these are changing and it seems they keep getting overwritten. I'm going crazy over this, can we please not create any baselines uuntil after the release which should stabilize the metrics baselines. After the release I plan on taking metrics tests out completely and move them to their own space.

@danlipsa
Copy link
Contributor Author

@doutriaux1 Can we push stuff the existing baselines and trigger new builds? If that gets in your way I can wait until this is fixed. Let me know.

@doutriaux1
Copy link
Contributor

@danlipsa I'm afraid you'll have to re-update the baselines after, not sure.

@danlipsa danlipsa mentioned this pull request Mar 30, 2016
Closed
@danlipsa
Copy link
Contributor Author

@doutriaux1 Thats fine. Let me know when master is fixed and I can rebase.

@danlipsa danlipsa mentioned this pull request Mar 30, 2016
Closed
@danlipsa
Copy link
Contributor Author

@jbeezley Is garant working? It's been working at the tests for a while.

@jbeezley
Copy link
Contributor

I turned it off because it has been consistently failing for several weeks now due to network timeouts, and I don't have the time to fix it. I just removed it as an expected status, so it should no longer show up.

@danlipsa
Copy link
Contributor Author

@doutriaux1 @aashish24 Any update on the failing tests on master? diags_test_... and vcs_test_continents and vcs_read_old_scr_2 still fail there. Maybe we should remove the offending commit.

@danlipsa
Copy link
Contributor Author

danlipsa commented Apr 7, 2016

@doutriaux1 @aashish24 Do I merge this in or any of you want to merge it?

@danlipsa
ENH: ratio=autot works for geographic projected datasets.
c264c2d 
ratio=autot does not work for linear projection meshfill.
We leave this for a future commit as it requires further restructuring
of the code.
@danlipsa danlipsa merged commit ce6f078 into master Apr 8, 2016
@danlipsa danlipsa mentioned this pull request Apr 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlipsa @aashish24 @doutriaux1 @jbeezley