New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #1886: Polar projection does not change pole. #1904

Merged
merged 1 commit into from Apr 8, 2016

Conversation

Projects
None yet
3 participants
@danlipsa
Contributor

danlipsa commented Apr 1, 2016

Polar projection should use:
South Pole for y1 < y2
North Pole for y1 > y2.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 1, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 1, 2016

@doutriaux1 @aashish24 Please review. See also the issues observed while debugging this:
#1901
#1903
#1905

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 1, 2016

The following tests still fail on master and on this branch:
43 - vcs_read_old_scr_2 (Failed)
423 - vcs_test_continents (Failed)
561 - diags_test_02 (Failed)
562 - diags_test_03 (Failed)
563 - diags_test_04 (Failed)
564 - diags_test_41 (Failed)
565 - diags_test_05 (Failed)
566 - diags_test_06 (Failed)
567 - diags_test_07 (Failed)
568 - diags_test_08 (Failed)
569 - diags_test_09 (Failed)
570 - diags_test_10 (Failed)
571 - diags_test_11 (Failed)
572 - diags_test_12 (Failed)
573 - diags_test_13 (Failed)
574 - diags_test_15 (Failed)

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 6, 2016

@danlipsa why there is a hole in test_vcs_basic_isofill_-3_proj_gmflip_NH_via_gm.png?

# We don't use the zooming feature (gm.datawc) for geographic
# projections. We use wrapped coordinates for doing the projection
# We use zooming feature (gm.datawc) for linear and ploar projections.
# We use wrapped coordinates for doing the projection

This comment has been minimized.

@aashish24

aashish24 Apr 6, 2016

Contributor

this sentence does not read well --> such that parameters such that central meridian are set correctly

@danlipsa could you please clean it up?

This comment has been minimized.

@danlipsa

danlipsa Apr 6, 2016

Contributor

Sure, I'll cleanup the comment. The command for test_vcs_basic_isofill_-3_proj_gmflip_NH_via_gm.png is

"/home/danlipsa/src/uvcdat/testing/vcs/test_vcs_basic_gms.py" "--gm_type=isofill" "--projection=-3" "--lat1=90" "--lat2=0" "--range_via_gm" "--gm_flips_lat_range" "--source=/home/danlipsa/build/uvcdat/uvcdat-testdata/baselines/vcs/test_vcs_basic_isofill_-3_proj_gmflip_NH_via_gm.png"

so
(90, 0) flipped -> (0, 90).
which means view from the South.
The hole is (-90, 0). Note the NH which is appended to the file is wrong: #1903

# such that parameters such that central meridian are set correctly
if (gm.g_name == 'Gfm'):

This comment has been minimized.

@aashish24

aashish24 Apr 6, 2016

Contributor

What does Gfm stands for?

This comment has been minimized.

@danlipsa

danlipsa Apr 6, 2016

Contributor

meshfill

@@ -1595,7 +1595,7 @@ def plot(self, x, slab, gm, bg=0, min=None,
Y = slab.getAxis(-2)
wc2 = vcs.utils.getworldcoordinates(gm, X, Y)
wc2 = kargs.get("dataset_bounds", wc2)
wc2 = kargs.get("plotting_dataset_bounds", wc2)

This comment has been minimized.

@aashish24

aashish24 Apr 6, 2016

Contributor

where is plotting_dataset_bounds defined?

This comment has been minimized.

@danlipsa

danlipsa Apr 6, 2016

Contributor

VTKPlots.py

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 6, 2016

@danlipsa I have some questions but I see the pattern for meshfill which seems reasonable to me but I will have detailed look after I get the answers.

@danlipsa danlipsa force-pushed the boxfill-polar branch from 79ac028 to f358cca Apr 6, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 6, 2016

@danlipsa meshfill will be fixed in a separate PR correct?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 6, 2016

@doutriaux1 Yes, we can definitely work on fixing the meshfill. #1905

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 6, 2016

Ok I'll test the updated PR and merge in then.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 6, 2016

@doutriaux1 Note meshfill might be trickier to get working as zooming does not work correctly for it:
#1912

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 7, 2016

@doutriaux1 @aashish24 Do I merge this in or any of you want to merge it?

BUG #1886: Polar projection does not change pole.
Polar projection should use:
South Pole for y1 < y2
North Pole for y1 > y2.

@danlipsa danlipsa force-pushed the boxfill-polar branch from f886e96 to ac9d21e Apr 8, 2016

@danlipsa danlipsa merged commit 0f1248f into master Apr 8, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment