-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup for conda and setuptools #1908
Conversation
LGTM 👍 |
@doutriaux1 I am going to update the branch with current master to trigger build again. |
@aashish24 thanks |
@doutriaux1 can we merge this branch? |
@doutriaux1 I am going to build this branch from scratch and if builds and runs fine, I am going to merge it into master since you said we needed this asap in master. |
@aashish24 yes please pretty please merge this. |
Okay, I will merge it after I update it to current master and run it again manually. |
Still building... |
40 - flake8_vcs (Failed) |
|
[chaudhary@einstein build_debug]$ ctest -R "test_unidata_basic_functionalities" -V 541: Test command: /home/chaudhary/tools/uvcdat/build_debug/install/bin/runtest "/home/chaudhary/tools/uvcdat/build_debug/install/bin/python" "/home/chaudhary/tools/uvcdat/src.git/testing/unidata/test_udunits.py" 0% tests passed, 1 tests failed out of 1 |
@doutriaux1 few new tests are failing on my machine. Can you confirm if they are failing for you as well? |
let me run it here as well |
similar issues as you @aashish24 looking into it right now: The following tests FAILED: |
@aashish24 @chaosphere2112 thinks the vcs_test_continents is meesed up and should be updated. I fixed the other issues, I think it's worth merging in asap and fix vcs_test_continent in a separate PR. |
@doutriaux1 I totally agree with you. it has been broken for some time see message from @danlipsa. I will test your branch again and if other tests are passing, then will give +2 today. |
LGTM +2
|
Thnaks @aashish24 I'll be sending a PR with updated baselines for diags shortly. |
@aashish24 @chaosphere2112 can we p[lease review and merge this super fast, master is broken without out: