Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent test names and other related issues #1917

Merged
merged 2 commits into from Apr 7, 2016

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Apr 7, 2016

From now on, we will follow this naming convention

  1. test_vcs --> test vcs code
  2. test_cdms --> test cdms IO code
  3. test_genutil --> test utility code
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 7, 2016

@UV-CDAT/developers its not ready for review yet. I am just posting it here so that you know its coming soon + plus I need to look at the diff carefully (how github is showing it).

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 7, 2016

Also, I may push sorting as different branch since I had to update my branch with latest changes which was little tricky.

@aashish24 aashish24 force-pushed the fix_tests_consistent_names branch from c080bea to 8e2718e Apr 7, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 7, 2016

@aashish24 aashish24 force-pushed the fix_tests_consistent_names branch from a885731 to 500a4a6 Apr 7, 2016
aashish24 added 2 commits Apr 7, 2016
From now on, we will follow this naming convention
1) test_vcs --> test vcs code
2) test_cdms --> test cdms IO code
3) test_genutil --> test utility code
@aashish24 aashish24 force-pushed the fix_tests_consistent_names branch from 500a4a6 to 309fcb9 Apr 7, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 7, 2016

  • This branch fixes few issues mainly related naming inconsistencies
  • I have done partial sorting of names but will push another branch to finalize that

I would like this to be merged to master asap so that I can avoid the conflict again if possible.

@doutriaux1 @danlipsa

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 7, 2016

@danlipsa @chaosphere2112 I believe @doutriaux1 is out. Could you two
please review it?

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 7, 2016

LGTM.

@aashish24 aashish24 merged commit 7eab04f into master Apr 7, 2016
2 checks passed
@aashish24 aashish24 deleted the fix_tests_consistent_names branch Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants