-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing test file #1918
Added missing test file #1918
Conversation
Folks, I am running the entire test-suite as Dan found 3 new tests failing. |
Yes, now that test passes on your branch. |
LGTM |
86ebc90
to
8ddfda2
Compare
@danlipsa sorry, I am not done yet. I just wanted to let folks know that I am working on fixing them and that's why the PR. I will be done in few minutes. |
Sounds good. |
@danlipsa this branch is ready to be reviewed. The only other test failing is the continent on my machine but it seems like it couldn't not be caused by my branch since it shaving a very small diff which looks more like a aliasing or some other issue not related to my branch. |
Ref: #1919 |
@aashish24 See the end of this PR where I listed all failing tests. What about test_vcs_wmo_markers? That is still failing. |
@danlipsa that is because I pushed the data afterwards (my bad): Its here; CDAT/uvcdat-testdata#124 |
@aashish24 Indeed, with that data all 3 test pass now. LGTM. |
thansk! |
No description provided.