Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing test file #1918

Merged
merged 2 commits into from Apr 8, 2016
Merged

Added missing test file #1918

merged 2 commits into from Apr 8, 2016

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Apr 8, 2016

No description provided.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

Folks, I am running the entire test-suite as Dan found 3 new tests failing.

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 8, 2016

Yes, now that test passes on your branch.

@danlipsa danlipsa closed this Apr 8, 2016
@danlipsa danlipsa reopened this Apr 8, 2016
@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 8, 2016

LGTM

@aashish24 aashish24 force-pushed the fix_failing_tests_rename branch from 86ebc90 to 8ddfda2 Apr 8, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

@danlipsa sorry, I am not done yet. I just wanted to let folks know that I am working on fixing them and that's why the PR. I will be done in few minutes.

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 8, 2016

Sounds good.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

@danlipsa this branch is ready to be reviewed. The only other test failing is the continent on my machine but it seems like it couldn't not be caused by my branch since it shaving a very small diff which looks more like a aliasing or some other issue not related to my branch.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

Ref: #1919

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 8, 2016

@aashish24 See the end of this PR where I listed all failing tests.
CDAT/uvcdat-testdata#121
continents is failing for a long time, so it wasn't you. :-)

What about test_vcs_wmo_markers? That is still failing.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

@danlipsa that is because I pushed the data afterwards (my bad): Its here; CDAT/uvcdat-testdata#124

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Apr 8, 2016

@aashish24 Indeed, with that data all 3 test pass now. LGTM.

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Apr 8, 2016

thansk!

@aashish24 aashish24 merged commit 7227709 into master Apr 8, 2016
2 checks passed
@aashish24 aashish24 deleted the fix_failing_tests_rename branch Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants