Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode strings for subsetting. #1941

Merged
merged 3 commits into from
Apr 26, 2016
Merged

Conversation

danlipsa
Copy link
Contributor

This is how they come from the web.

@doutriaux1
Copy link
Contributor

wow there are still some types floating around! I thought I removed them all! Maybe we should check the rest of the file(s) for use of types and clean this up as well

This is how they come from the web.
@danlipsa
Copy link
Contributor Author

Sure, I can do the string ones. What do you do for the rest of the types?

@danlipsa
Copy link
Contributor Author

https://gitlab.kitware.com/UV-CDAT/uvcdat/merge_requests/614
@doutriaux1 @aashish24 I think this is ready. We can clean up in a different PR.

@aashish24
Copy link
Contributor

Dashboard looks good to me thanks to @sankhesh' effort. LGTM 👍

@doutriaux1
Copy link
Contributor

@aashish24 @sankhesh is that the url for buildbot results? https://gitlab.kitware.com/UV-CDAT/uvcdat/merge_requests/614/builds ? I only see kitware there, I thought we had at least oceanonly and crunchy going.

@sankhesh
Copy link
Contributor

@doutriaux1 Nope. Buildbot auto-generates a custom CDash link for builds specific to the merge request and posts a comment on the merge request.

Here is an example: https://gitlab.kitware.com/UV-CDAT/uvcdat/merge_requests/614#note_90623

@doutriaux1
Copy link
Contributor

thanks @sankhesh

@doutriaux1
Copy link
Contributor

@danlipsa there's failure on the few bots we have.

@danlipsa
Copy link
Contributor Author

@doutriaux1 Are you talking about oceanonly? Those tests fail on master as well. There is the diag tests that fail for some time and recently I started seeing some vcs_verify tests failing because they cannot find a py file.

@danlipsa
Copy link
Contributor Author

@doutriaux1 Ready to merge?

@doutriaux1
Copy link
Contributor

@danlipsa while we are at it I would like to clean this up a bit more, I'll push an updated version in 10mn

@danlipsa
Copy link
Contributor Author

@doutriaux1 We could always do the clean-up as a separate PR. I would rather do it that way instead of delaying this any further.

@danlipsa danlipsa merged commit 1c84b48 into master Apr 26, 2016
@danlipsa
Copy link
Contributor Author

@doutriaux1 This is the issue so that we don't forget
#1950

@doutriaux1
Copy link
Contributor

@danlipsa ok just pushed the changes I wanted. Please review and merge if tests pass for you.

@doutriaux1
Copy link
Contributor

@danlipsa I see you already merged it... Oh well...

@danlipsa
Copy link
Contributor Author

@doutriaux1 Just make another PR and I can review it and merge it quickly.

@doutriaux1
Copy link
Contributor

@danlipsa see: #1951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants