New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continents=0 #1956

Merged
merged 2 commits into from May 3, 2016

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented Apr 28, 2016

Fixes an issue where plotting without continents would break stuff indefinitely. Test inbound.

chaosphere2112 and others added some commits Apr 28, 2016

Sam Fries
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Apr 28, 2016

@doutriaux1 @aashish24 @danlipsa Please review. Bumped into this while doing an example for someone, should go in 2.4.2.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 29, 2016

LGTM 👍 you meant 2.6? I don't think we talkd about 2.4.2?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 2, 2016

ping @chaosphere2112 just wanted to make sure you saw my +2

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 3, 2016

@aashish24 I was confused about a UVCMetrics thing; UVCMetrics is getting a 2.4.2, but since it's now decoupled from UV-CDAT's release cycle, we won't be having a corresponding release. Should go in 2.6, though. Sorry, I've been out sick for a few days.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 3, 2016

@aashish24 I was confused about a UVCMetrics thing; UVCMetrics is getting a 2.4.2, but since it's now decoupled from UV-CDAT's release cycle, we won't be having a corresponding release. Should go in 2.6, though. Sorry, I've been out sick for a few days.

No problem. thanks for the update. this branch is good to go if you want to merge it.

@chaosphere2112 chaosphere2112 merged commit 0576bbe into master May 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@chaosphere2112 chaosphere2112 deleted the fix_no_continents branch May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment