Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continents=0 #1956

Merged
merged 2 commits into from
May 3, 2016
Merged

Fix continents=0 #1956

merged 2 commits into from
May 3, 2016

Conversation

chaosphere2112
Copy link
Contributor

Fixes an issue where plotting without continents would break stuff indefinitely. Test inbound.

@chaosphere2112 chaosphere2112 mentioned this pull request Apr 28, 2016
Closed
@chaosphere2112
Copy link
Contributor Author

@doutriaux1 @aashish24 @danlipsa Please review. Bumped into this while doing an example for someone, should go in 2.4.2.

@aashish24
Copy link
Contributor

LGTM 👍 you meant 2.6? I don't think we talkd about 2.4.2?

@aashish24
Copy link
Contributor

ping @chaosphere2112 just wanted to make sure you saw my +2

@chaosphere2112
Copy link
Contributor Author

@aashish24 I was confused about a UVCMetrics thing; UVCMetrics is getting a 2.4.2, but since it's now decoupled from UV-CDAT's release cycle, we won't be having a corresponding release. Should go in 2.6, though. Sorry, I've been out sick for a few days.

@aashish24
Copy link
Contributor

@aashish24 I was confused about a UVCMetrics thing; UVCMetrics is getting a 2.4.2, but since it's now decoupled from UV-CDAT's release cycle, we won't be having a corresponding release. Should go in 2.6, though. Sorry, I've been out sick for a few days.

No problem. thanks for the update. this branch is good to go if you want to merge it.

@chaosphere2112 chaosphere2112 merged commit 0576bbe into master May 3, 2016
@chaosphere2112 chaosphere2112 deleted the fix_no_continents branch May 3, 2016 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaosphere2112 @aashish24